Closed (won't fix)
Project:
Views (for Drupal 7)
Version:
7.x-3.x-dev
Component:
comment data
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
24 Apr 2012 at 11:44 UTC
Updated:
14 May 2012 at 08:15 UTC
Jump to comment: Most recent file
Comments
Comment #1
barbun commentedHere goes my patch for comment.module and Views:
Using git, in a drupal root:
git apply -v comment-disapprove-link-1545220-2.patchgit apply -v --directory=PATH_TO_VIEWS_CONTRIB_MODULE views-comment-disapprove-link-1545220-2.patchComment #3
barbun commentedSorry, patch in #1 had wrong module directory. Here's the correct one.
Also, patch for comment.module cannot be automatically applied, because of different for apply.
See my issue for comment.module: http://drupal.org/node/1545220
Comment #4
barbun commentedComment #5
tim.plunkettThe new include file also needs an entry in views.info.
Comment #6
barbun commentedThanks, Tim! My bad.
Here's the updated one.
Comment #8
barbun commentedComment #10
barbun commentedComment #11
dawehnerYou could actually drop this line and just $comment = $this->get_value($values); below. The entity is loaded anyway.
You could actually drop this line and just $comment = $this->get_value($values); below. The entity is loaded anyway.
The rest though looks RTBC
Comment #12
barbun commentedGot it, thanks!
Comment #14
barbun commentedComment #16
barbun commentedComment #16.0
barbun commentedAdded link
Comment #18
dawehnerThanks this looks perfect now! After some really minor changes committed it to 7.x-3.x.
Comment #19
dawehnerOOOOH actually views will never contain features which aren't supported by core.
I reverted your patch, as it doesn't make sense to add a non-supported feature to views, sorry.
As d7 is feature frozen the patch will never land there, but as you know you can use your module as well.
Comment #19.0
webchickAdded link to a contributed module.