FAQ's are no longer filtered by language AND categories are not translated

Well if you're using the supplied Views that come with the FAQ module and if the problem is with Views, then there's not much I can do for you here. Did you try JGO's suggestion from comment #10 in that issue? http://drupal.org/node/1543416#comment-5920280 Did that work for you?

On the other hand, if you're using the built-in page that FAQ module provides at /faq-page, then that's different and I'd need to look into it further.

Upgraded to i18n-7.x-1.5 and am having the same problem in the non-Views listing, see my comment at http://drupal.org/node/1543416#comment-5935058 Need to wait for feedback to that.

In Drupal 6, the FAQ module just provided a custom built-in page at /faq which wasn't powered by Views. You could control the layout of it in the FAQ admin settings. In D7, this page is now at /faq-page. The other faq listings the module provides are built using the Views module. Both appear to be affected and could potentially be a problem in the i18n module. I'm waiting on more information from the i18n maintainer.

marking as a blocker

go to admin/config/regional/i18n/select
remove the "views" from skip tags...that solves the problem!!

regds,
parag

Yeah removing the "views" tag is not really a stable solution. I've updated the Views code and also the in-built faq-page listing to accommodate the changes made in i18n 7.x-1.5 and both are working here for me now. It will be included in the next dev release of the module. I'd appreciate testing feedback if people have the time.

Prob not, but it's in the one from 17th June for sure

Correction I have made to correct this issues

• go to \sites\all\modules\faq\faq.module
• around line 464 add $langcode = $GLOBALS['language_content']->language;
  

      $default_sorting = variable_get('faq_default_sorting', 'DESC');    
      $langcode = $GLOBALS['language_content']->language;
      $query = db_select('node', 'n');
  

• around line 468 change

      $query
        ->addTag('node_access')
        ->fields('n', array('nid'))
        ->condition('n.type', 'faq')
        ->condition('n.status', 1)
             ->condition(db_or()->condition("$weight_alias.tid", 0)->isNull("$weight_alias.tid"));
  

  by

      $query
        ->addTag('node_access')
        ->fields('n', array('nid'))
        ->condition('n.type', 'faq')
        ->condition('n.status', 1)
        ->condition('n.language ', $langcode)
        ->condition(db_or()->condition("$weight_alias.tid", 0)->isNull("$weight_alias.tid"));
  
  

I hope it will Okay for you !

I have installed the dev from 17 June. This has not fixed the problem for me.

Am I supposed to add a filter to the FAQ view? I am using the built-in page at /faq-page

Is there anything else I am supposed only see the FAQ Q&As in the user's selected language.

(flushed buffers)

I made modifications to the code as suggested in comment #14 and now it is working as I want it to. Those mod were not in the June 17 dev release that I installed. Just installing that release did not solve the problem.

#14 solved it (FAQ 7.x-1.0-rc2, i18n 7.x-1.7 and Views 7.x-3.5)
Thanks

I haven't tested this yet, but on glance it looks like it doesn't properly consider content that is set to LANGUAGE_NONE.

OK, so what this thread fails to mention is that the adjustments that were made to get the language support working require the i18n_select module to be enabled.

works like a charm, thx!

Hi, I have created a small patch based on the solution in this issue http://drupal.org/node/1543416. Tested it and it seems to work.

I go this after applying the patch. anyone else got this?
Fatal error: Call to undefined function i18n_select_langcodes() in /var/www/vhosts/techshuk.com/sites/all/modules/faq/faq.module on line 472

odizle, did you enable the i18n_select module as said in #23?

Len

I wonder what on earth I could be doing wrong at this point? I applied the above patch to the dev/RC versions of FAQ, enabled the Multilingual select module, translated both the FAQ pages and the taxonomy terms, etc. yet I still can't seem to get the FAQ to display in the non-default language.

I originally had the issue mentioned by the OP where both the untranslated and translated versions were showing up, but now I can only see the default language.

If I recall correctly, I believe when I enabled the Multilingual select module, that's when only the default language was being displayed.

Would someone be so kind as to post their settings on a working site? Are people using the Title module to replace the name field? What are your "Multilingual options" on your FAQ taxonomy? What about the FAQ content type's "Multilingual support" setting?

For the most part, the rest of my site is fully translated and working.

Thanks.

For me the default FAQ page (I don't use Views) was showing two languages. Updating to dev version didn't help, but enabling the Multilingual select module (from i18n) did.

Thank you for all the suggestions from this thread.

So my issue in #28 was solved by changing the "Categories layout" at /admin/config/content/faq/categories to "Don't display". If I try either "Clicking on category opens/hides questions and answers under category" or what I really want "Categories inline", I get an empty screen at /language/faq-page except for the two tabs at the top of the page.

Anyone get this working with Categories?

The patch in #25 worked for me to a point. I'm using Categories, and still have the problem when the categories layout is anything other than "don't display". I don't get the empty screen described in #30. I get everything as expected minus the actual translated term. For instance, I get the correct counts under a category/term. Eg, for 1 translated term with a faq in 2 languages, it shows a count of 1 not 2 (where it did show 2 before applying this patch). If I switch to the language the faq is translated to, I see only those terms/categories that have faqs in that langauge, I see the correct counts (different from the source language), but I do not see the translated term/category.

I'm wondering if the untranslated terms are related to this issue: #1371696: Taxonomy terms not translated when viewing/editing node

Or, if not that one, something else in i18n? The reason I say that is because I actually *do* see the translated terms in the term reference select on the node edit page for a faq translation. So, what else could be causing the terms to not be translated on the faq page?

I think I found the issue. The function faq_tt() is relying on the deprecated (for D7) function tt().

There's probably more refactoring that could be done here. Anyone who's more familiar with these modules, feel free to suggest better fixes.

Also, I tested this is working for me using a vocabulary with translation mode "localized". Not sure if there are any side effects for other modes.

On rc2 all faq questions showed for me. Upgrading to -dev fixed this, showing only the current language. No other changes, no patches. Multilingual select was activated since before.

fixed a spelling error

I've followed instructions from #14
Posted by Atragene on June 18, 2012 at 6:32pm

and it worked like a charm.
thanks

#14 is working ... thanks man

7.x-1.x-dev needs to be fixed as #14 to work correctly.

thanks to Atragene

patch doesn't apply. Needs reroll

There are several basic problems here.

1. The intent of the i18n_select module (a submodule of i18n module) is to automatically handle node queries and provide only the nodes that match the user's language. It does this by adding the user's language to any node query it encounters which do not already have either a) a query on the language or b) a query tag which says "stay away", which is configurable in the admin UI. So the overall intent of having i18n_select turned on is to *not* introduce code into a module to select by language.
2. However, i18n_select bails on complex queries, and the query used by FAQ in the *non-categorized* if/else of faq_page() is complex. (Line 269 of i18n_select.module). (The non-categorized query in faq_page() does a very exciting ->condition(db_or()->condition("$weight_alias.tid", 0)->isNull("$weight_alias.tid")); which is definitely not something i18n_select can sort out.

. This is the reason that the suggestion in #14 both works (and is required because i18n_select doesn't grok the situation).

3. There are several places in the faq.module where the pattern is "if i18n_select is enabled, then add the language query". Which is really not the intent at all. If we want i18n_select to alter the query, we do *nothing*. If we don't want it to alter the query, we add a tag to it. There's a default tag, i18n_select, that can be added to disable ii18n_select for any query.
4. The *categorized* section of faq_page() has a simpler query, but FAQ module has an override saying "if i18n_select is enabled, add a language query". That should probably be removed, and we can rely on i18n_select
5. Taxonomy term translation via tt() has long been obsolete, so was not being done here, as pointed out in #32. The approach in #32 is correct, to switch from tt() to i18n_taxonomy_localize_terms().

I'm going to experiment a little bit more to see if there's a way to simplify that query so we could depend completely on i18n_select and let it do its job. In that case we could remove a bit of code and end up with a simpler situation.

Updating title to reflect the various problems.

Here is the patch to address the issues in #40. Note that you *must* enable i18n_select module, part of the i18n module, for selection of proper FAQ answers to be done.

#42needs a reroll after recent commits.

Any update on this old issue?

The problem still exists in faq 7.x-1.1 and drupal 7.56.