This works beautifully, except for when the filefield is limited to only one item. I'm presuming that plupload can still handle single file uploads nicely, and will apply all it's benefits (chunking, progress etc.) to a single item upload. I'm also presuming that this issue can be resolved here, rather than in the filefield sources module.

Thanks

Simon

CommentFileSizeAuthor
#12 filefield_sources_plupload-Support-single-file-cardinality-1549848-12.patch4.64 KBmuschpusch
#9 filefield_sources_plupload-Support-single-file-cardinality-1549848-9.patch4.36 KBosman
#3 filefield_sources_plupload-Enable-single-file-uploads-1549848-3.patch5.09 KBosman

Comments

atlea’s picture

atlea commented
Assigned: Unassigned » atlea

Hum. I will have to look into limiting the number or files. I'll add this to the todo!

burgs’s picture

burgs commented

Atlea, you are a legend. It looks like the plupload team themselves don't really have an elegant, documented solution for this, so that might be a small issue. Let me know where I can help.

osman’s picture

osman
Location Copenhagen
commented
Status: Active » Needs review
StatusFileSize
new filefield_sources_plupload-Enable-single-file-uploads-1549848-3.patch5.09 KB

I believe I have a solution. Please review and test it.

Edit: There are some proper labeling issues, and typos, etc. But the functionality should be ready for reviewing.

adam_b’s picture

adam_b commented

Works well for me - many thanks :)

atlea’s picture

atlea commented

Nice one! I'll try to have a new dev that includes this functionallity over the weekend. :)

Tsubo’s picture

Tsubo commented

Has patch #3 been committed yet?

trebol’s picture

trebol commented

I cant apply the patch by atlea, because the code of the patch its different of the code i see in my module. i got the last version installed, and this option is not added.

Any valid script to enable single file upload?

antipode’s picture

antipode commented

great - I tried something myself but was not aware of the $element['#attached']['js'][].

however - I still get the option to add more files when uploading. I thought this patch will allow only for 1 file to select and upload.

osman’s picture

osman
Location Copenhagen
commented
StatusFileSize
new filefield_sources_plupload-Support-single-file-cardinality-1549848-9.patch4.36 KB

Here is an updated patch.

If cardinality is set to "1", Plupload is forced to select only one file at a time in "file select" dialog windows by adding multi_selection: FALSE and multiple_queues: FALSE settings to plupload object.

If cardinality is set to anything but unlimited; number of the files in the queue is checked on "QueueChanged" event.
Files exceeding the limit are removed from the queue instantly. Meanwhile, Add files link/button is kept hidden when the number of the files in the queue matches the (cardinality) limit.

I tested this with different cardinality settings. But please do test it yourselves as well.

osman’s picture

osman
Location Copenhagen
commented

Forgot to mention; with this patch cardinality value is passed to plupload object as a setting. So it would be available at all times.
Later it is used in plupload.js as pluploadSettings.cardinality in QueueChanged event.

muschpusch’s picture

muschpusch commented
Status: Needs review » Reviewed & tested by the community

ok this patch is awesome because of two reasons:

- single file upload (my usecase i use plupload because of chunking large files)
- cardinality is checked before uploading on plupload side

muschpusch’s picture

muschpusch commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new filefield_sources_plupload-Support-single-file-cardinality-1549848-12.patch4.64 KB

ok just some little adjustments to the label

atlea’s picture

atlea commented
Status: Needs review » Fixed

Patch seems to work nicely. I have added it to the dev-version.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.