This is very close, I know there should be one test failure, and it's a legit bug, but I want to get soem review on this, and see what the testbot says.

I'd like to look at one or two of the other maintainers bugs while I'm at it, and I need to grep through 6.x-1.x for all references to maintainers to make sure I'm not missing anything.

CommentFileSizeAuthor
#7 1549854-port_project_maintainers-6.patch35.27 KBmikey_p
#6 1549854-port_project_maintainers-5.patch9.52 KBmikey_p
#2 1549854-port_project_maintainers-2.patch35.19 KBmikey_p
project-maintainers-port.patch29.22 KBmikey_p

Comments

Status: Needs review » Needs work

The last submitted patch, project-maintainers-port.patch, failed testing.

mikey_p’s picture

mikey_p commented
Status: Needs work » Needs review
StatusFileSize
new 1549854-port_project_maintainers-2.patch35.19 KB

This should be passing now, and also fixes #1003674: Deleting a project does not delete maintainers by including hook_node_delete().

mikey_p’s picture

mikey_p commented

This also now includes updated project.api.php docs. Yay for docs.

mikey_p’s picture

mikey_p commented
Issue tags: +project, +drupal.org D7

Tagging for sprint

Status: Needs review » Needs work

The last submitted patch, 1549854-port_project_maintainers-2.patch, failed testing.

mikey_p’s picture

mikey_p commented
Status: Needs work » Needs review
StatusFileSize
new 1549854-port_project_maintainers-5.patch9.52 KB

Pretty sure the previous patch won't apply, since I hadn't pulled recently.

mikey_p’s picture

mikey_p commented
StatusFileSize
new 1549854-port_project_maintainers-6.patch35.27 KB

Whoops that patch was missing a large hunk.

mikey_p’s picture

mikey_p commented
Status: Needs review » Fixed

Committed.

Automatically closed -- issue fixed for 2 weeks with no activity.