As xtfer requested, I open a new issue for this problem.
Summary of the problem:
"When I updated to the 6.x-2.x branch, update.php threw some errors and the table 'ds_settings' hasn't been created :

User warning: BLOB/TEXT column 'settings' can't have a default value
User warning: BLOB/TEXT column 'fields'  can't have a default value

This is a valid warning, as I found out in the MySQL documentation: " BLOB and TEXT columns cannot have DEFAULT values." (http://dev.mysql.com/doc/refman/5.5/en/blob.html)

I found it strange that this hasn't been spotted by more people, but I think it's only an issue if you set your MySQL database to be very strict with the input (sql_mode = 'STRICT_TRANS_TABLES'), which is the case in my institute on our innoDB MySQL databases."

It shouldn't affect most people, only the ones running MySQL in strict mode.
The fix is quite simple as it only involves removing 'default' => '', from the definitions of the 'settings' and 'fields' column in ds.install

I'll attach a patch in the next post.

CommentFileSizeAuthor
#5 ds-remove_default_for_text_columns-1550654-5.patch1.43 KBtlaurent
#3 ds-remove_default_for_text_columns-1550654-3.patch1.18 KBtlaurent
#2 ds-remove_default_for_text_columns-1550654-2.patch902 bytestlaurent
#1 ds-remove_default_for_text_columns-1550654-1.patch499 bytestlaurent

Comments

tlaurent’s picture

tlaurent commented
StatusFileSize
new ds-remove_default_for_text_columns-1550654-1.patch499 bytes

This should fix it for 6.x.2.x branch.

tlaurent’s picture

tlaurent commented
Status: Active » Needs review
StatusFileSize
new ds-remove_default_for_text_columns-1550654-2.patch902 bytes

Sorry, done a half-baked job with the previous patch: I forgot to remove 'default' in ds_update_6201 as well...
That's corrected in this new patch.

tlaurent’s picture

tlaurent commented
StatusFileSize
new ds-remove_default_for_text_columns-1550654-3.patch1.18 KB

In ds_update_4() the records are re-added to the table without anything for the 'fields' column, but this column doesn't accept NULL, so in this new patch I took that into account and added $record->fields = ''; to avoid the problem.
But I'm not sure it's the right solution, or if 'fields' should accept NULL.

xtfer’s picture

xtfer commented

Thank you very much. I'll look at this as soon as possible.

tlaurent’s picture

tlaurent commented
StatusFileSize
new ds-remove_default_for_text_columns-1550654-5.patch1.43 KB

I noticed that one last thing was upsetting MySQL strict: trying to create a table when it's already there. It throws an error and stops the Drupal update. GOD this thing is picky !!!
So, I re-rolled a new patch which checks if the table (ds_settings) is there before trying to create it, and drop it 1st if it's there.

    if (db_table_exists($name)) {
      db_drop_table($ret, $name);
    }

After installing this final patch (this patch also include all the changes from the previous patches), everything seems to have been updated and no errors or warnings have been generated.

ThePhantom’s picture

ThePhantom commented

When editing product fields in a catalog, upon saving you get the following error.

user warning: Field 'fields' doesn't have a default value query: drupal_write_record /* ThePhantom : drupal_write_record */ INSERT INTO ds_settings (module, type, build_mode, settings) VALUES ('nd', 'product', 'grid', 'a:3:{s:6:\"fields\";a:1:{s:5:\"links\";a:5:{s:6:\"region\";s:4:\"left\";s:6:\"weight\";s:3:\"-19\";s:6:\"format\";s:0:\"\";s:9:\"css-class\";s:0:\"\";s:11:\"labelformat\";s:6:\"hidden\";}}s:6:\"status\";i:1;s:13:\"region_styles\";a:5:{s:6:\"header\";s:0:\"\";s:4:\"left\";s:0:\"\";s:6:\"middle\";s:0:\"\";s:5:\"right\";s:0:\"\";s:6:\"footer\";s:0:\"\";}}') in C:\Web\Apache Software Foundation\Apache2.2\htdocs\web\includes\common.inc on line 3576.

I solved the problem by allowing ´fields´ to be empty (NULL).

'fields' => array(
        'description' => 'The fields of for this record.',
        'type' => 'text',
        'not null' => FALSE,
        'size' => 'big',

Please note that I don´t really know anything about Drupal or DS yet! Just wanted to give you a heads up!
Please update the issue with the correct fix so I can apply it. Thanks!

PS. I was able to install DS using your latest patch, thanks!

xtfer’s picture

xtfer commented
Status: Needs review » Needs work

Thanks @ThePhantom.

Looks like we'll need to check all the write operations...

aspilicious’s picture

aspilicious commented
Issue summary: View changes
Status: Needs work » Closed (won't fix)

Closing all the drupal 6 issues as support for that version has been dropped.