Diff module breaks webform component table structure

Have you tried changing your theme to see if its causing the problem?

Which theme are you using? Can you give more info on your browser. Try also with a different browser if you can.

Closing after lack of activity.

I have actually been experiencing this for a while. I was only annoying, not really debilitating, until 5.x-1.8 added on the form elements to adjust the weight and mandatory info settings. Now the Components fieldset on the node edit form is nearly unusable.

To give a bit more information: on the node/add form, the Components' field-item divs are organized in a table as they should be. After the new webform has been saved, however, the Components fieldset (now on the node/edit form) contains just a bunch of form-item divs with no table layout at all. I've attached a screen-shot to help with the explanation.

After some testing, it looks like this is because theme_webform_node_form isn't being called for the node/edit form.

I remember seeing in the webforms screencast that it was working properly in the garland theme, so I switched to that and nothing :/ I'm assuming it's a module conflict, so I'll see if I can't narrow it down a little by disabling some of my modules.

re-opening

Ok, this is being caused by the diff module (in my setup at least).

Looks like the diff module uses an implementation of hook_form_alter to set $form['#theme'] = 'diff_node_form';The theme_diff_node_form function then positions the diff module's "Preview Changes" button down with the other buttons at the end of the form.

When $form['#theme'] = 'diff_node_form'; in diff.module is commented out, the components are themed correctly.

Oddly enough, when that line is commented out, the "Preview Changes" button is still positioned correctly on webform node/nid/edit forms, but not on other node types' node/nid/edit forms.

I suspect that this conflict isn't specific to the diff & webform module combination, but I don't currently use any other modules that have a custom theme_node_form function, so I can't test that.

I'm also not sure which module should be fixed, if either. But my solution for now was to comment out both the diff_form_alter function and the theme_diff_node_form function from diff.module since I don't really use the "Preview Changes" button anyway.

I'll create an issue over on the diff side as well.

There is a diff patch for a different issue that fixes this one.

posted at: http://drupal.org/node/115411#comment-658374

That patch is also available in the latest 5.x-1.x-dev version of diff.

sorry, should have mentioned that after getting that patch, you need to go to /admin/content/types/webform on your site and un-check the "Show Preview changes button on node edit form" option at the bottom. The patch makes that setting available per content type.

Thanks ashtonium for the extensive research! That's quite helpful.

We might keep tabs on http://drupal.org/node/212951, which suggests moving the components to another tab instead of on the main node form. This would prevent incompatibilities with upload, taxonomy, and (apparently) diff modules. I'm sure there are others also that don't agree with the way webform handles the node form.

The webform 2.x branch corrects the problems with Diff module (and taxonomy, upload, imagefield, and others). I'm trying to get the 2.x version out and replacing 1.x as soon as possible to bring webform up to snuff in Drupal 5, and I'm recommending that if you need to use Diff and webform together, use the 2.x branch.

Trying to figure out what the "Show Preview changes button on node edit form" feature does? (i.e. how is it different to the default Preview button)