Closed (fixed)
Project:
Project
Version:
7.x-2.x-dev
Component:
Issues
Priority:
Normal
Category:
Feature request
Assigned:
Issue tags:
Reporter:
Created:
27 Apr 2012 at 19:17 UTC
Updated:
4 Jan 2014 at 02:05 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dwwIn D6 we have a global project_issue setting for default components for new projects. This settings form has even been ported to D7 thanks to #1545426: Project issue settings page port. However, the setting doesn't do anything. We should use it to pre-populate default components when you create new projects.
Comment #2
dwwOh duh. ;) this is just a core multi-valued text field. Core supports default values on fields. So, we should:
A) define default values for this field on the default project type we ship
B) rip out this setting entirely
C) document this change in the forthcoming upgrade guide. ;)
Comment #3
mikey_p commentedComment #4
senpai commented.
Comment #4.0
senpai commentedAdding a level of effort section to the summary.
Comment #5
mikey_p commentedI'm also planning ripping this setting out of project_issue, although to be honest it feels odd that the field is defined in project module, but only used by project_issue.
For now I'm going ahead and committing the attached patches. Does anyone think we should move the creation of this field to project_issue itself?
Comment #6
dwwI'm not sure how it'd work for project_issue to inject this field into the default/example project node type from project.module. Can you elaborate?
Otherwise, these commits look great. (Although you're living dangerously with # as the first character in your commit message you actually pushed to Git). ;)
Thanks!
-Derek
Comment #7
mikey_p commentedDoh, I've totally forgotten about the commit message thing, although considering it's pushed to d.o and we don't allow rewriting history I dont' suppose it makes much difference.
In term of injecting the field, it would be handled the same way that the current field_project_has_issue_queue is injected into project nodes in project_issue_install(): http://drupalcode.org/project/project_issue.git/blob/refs/heads/7.x-2.x:...
Comment #8
dwwOh, okay. I see what you mean. Sure, that'd be a good idea. The only reason to have a components field on project nodes is if you're using them for a component field on your issues...
Fire at will. ;)
Thanks,
-Derek
Comment #9
mikey_p commentedOpened up #1571378: Add field for project components to project nodes upon installation for the project_issue component of this patch.
The attached patch just removes everything regarding components form project, along with better use of t through get_t() in the install files.
Just going to wait on the test bot to test before committing.
Comment #10
mikey_p commentedComment #11
dwwLooks great, thanks!
Comment #12.0
(not verified) commentedChange an h2 to h3.