I'm not sure there's much we're going to be able to do in project_usage for core Field API stuff. I think this is going to be pretty much a straight port to the D7 API. We could potentially views-ify this, but I'm not sure it's worth the trouble. Mostly, I think this will be pretty simple. The only things to keep in mind:

- Make sure we're not hard-coding checks for 'project_project' and friends but instead using the new API from #1549538: Add a function to determine if a node or node type is a project
- Stop querying {project_projects} ;)
...

Comments

dww’s picture

Status: Active » Postponed
hunmonk’s picture

Assigned: Unassigned » hunmonk
Status: Postponed » Active

A good portion of the port won't be related to the changes in project_release module, so we can start this now.

senpai’s picture

Issue tags: +sprint 1
dww’s picture

@hunmonk: This probably goes without saying, but be sure to merge the recent fixes to project_usage from 6.x-1.x into 7.x-2.x before porting. In particular:

#428680: Change usage stats to not use google charts
#703720: The varnish merge

Not sure if we should just cherry pick, or try a full 6.x-1.x -> 7.x-2.x merge.

hunmonk’s picture

Status: Active » Needs review
Issue tags: -sprint 1

this port is now mostly done. couple of remaining things:

  1. {project_projects}.uri is used in the module, but i'm not sure where to get that from these days?
  2. {project_release_nodes} and {project_projects} are both referenced in the drush plugin, clearly that will need to be updated, but i figure we should wait until project and project_release have shaken out their data structure for 7.x
  3. the unit tests *should* pass, but project_usage depends on project_release currently, and that module still isn't ported -- seems best to deal with functional/unit testing once we have all deps working as well
  4. #1576640: kill project-usage-process.php and raw/daily db tables would be a nice cleanup i think, and would save porting project-usage-process.php
dww’s picture

1. {project_projects}.uri is the machine_name field on project nodes.

2. Not sure how {project_projects} is referenced in the drush plugin. I'd need more info to be able to answer that. {project_release_nodes} is almost certainly going away. Again, more data about how it's being used would be helpful.

3. Do the tests actually depend on releases, or just that usage wants to depend on releases?

4. I'll answer there. ;) Short version: -1.

Thanks!
-Derek

senpai’s picture

Issue tags: +sprint 1, +sprint 2

Tagging for Sprint 2.

senpai’s picture

Issue tags: +sprint 3

Tagging for sprint 3.

hunmonk’s picture

Status: Needs review » Postponed

progress today, got the missing machine name stuff worked out, and hammered on the summary page of all projects, it's now working perfectly.

the other usage pages really need a working project_release module to finish/test, and the tests are very simple to verify once the module has been fully ported, so postponing the rest of the work until project/project_release are more fully formed.

hunmonk’s picture

Assigned: hunmonk » Unassigned
dww’s picture

Status: Postponed » Active

I believe project_release is ported enough for work here to continue.

drumm’s picture

Priority: Normal » Major
Issue tags: +32hr
drumm’s picture

Priority: Major » Critical
drumm’s picture

Assigned: Unassigned » drumm
drumm’s picture

Status: Active » Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.