Download & Extend
Backup and Migrate » Issues

Rotation cleanup leaves info files

Posted by fgm on May 1, 2012 at 8:16am
Project:Backup and Migrate
Version:7.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

When using scheduled backups with a cleanup rotation, actual backup files are properly removed, but the association .info files describing the deleted backups remain in the target directory.

Login or register to post comments

Comments

#1

Posted by Mile23 on May 25, 2012 at 6:08pm

I'm seeing this, too.

~/shared/private/backup_migrate/scheduled/daily $ ls
MySite-2012-05-16T11-56-04.mysql.gz.info
MySite-2012-05-17T13-10-42.mysql.gz.info
MySite-2012-05-18T14-02-54.mysql.gz.info
MySite-2012-05-19T13-49-09.mysql.gz.info
MySite-2012-05-20T14-50-53.mysql.gz.info
MySite-2012-05-21T16-34-42.mysql.gz.info
MySite-2012-05-22T10-30-40.mysql.gz.info
MySite-2012-05-22T10-31-46.mysql.gz
MySite-2012-05-22T10-31-46.mysql.gz.info
MySite-2012-05-23T11-45-54.mysql.gz
MySite-2012-05-23T11-45-54.mysql.gz.info
MySite-2012-05-24T13-07-34.mysql.gz
MySite-2012-05-24T13-07-34.mysql.gz.info

#2

Posted by aitala on June 5, 2012 at 1:57pm
Version:7.x-2.x-dev» 7.x-2.4

This is also happening in the new 7.x-2.4 version as well for both manual and scheduled backups.

filename = "EarthSpaceSciencePartnership-2012-06-05T09-55-19"
description = ""
datestamp = "1338904519"
generator = "Backup and Migrate (http://drupal.org/project/backup_migrate)"
generatorversion = "7.x-2.x"
sites[0][version] = "7.14"
sites[0][name] = "Earth Space Science Partnership"
sites[0][url] = "http://d7.essp.psu.edu/"

Eric

#3

Posted by mermentau on June 8, 2012 at 8:01pm

I'm getting the same behavior as described in #2.

#4

Posted by magnusk on June 18, 2012 at 12:51pm

The function remove_expired_backups() in includes/schedules.inc is responsible for deleting expired backup files, but it ignores the corresponding .info files.

There are several functions involved in creating and reading metadata from .info files: save_file_info(), create_info_file(), and load_files_info() in includes/destinations.inc

#5

Posted by magnusk on June 18, 2012 at 12:55pm
Version:7.x-2.4» 7.x-2.x-dev

Leaving orphaned files does not seem minor.

What is the purpose of storing such metadata in these .info files?

#6

Posted by Mile23 on June 18, 2012 at 6:08pm
Priority:minor» normal

I agree not minor, but the files are small.

Also if you look at one of the .info files you'll see it's useful information that can't be easily retrieved from inside a gzip file. And I suppose it gets stored as an .info file because Drupal can easily read and write that format.

#7

Posted by Mile23 on June 19, 2012 at 8:10pm
Status:active» needs review

Here's a patch. It seems to work for file destinations. I don't have the resources at the moment to do a thorough test.

AttachmentSize
backup_migrate-infofiles_1555742.patch 1.49 KB

#8

Posted by attheshow on July 7, 2012 at 2:40pm

I'm also experiencing the problem with the .info files piling up on the server.

#9

Posted by Rory on July 26, 2012 at 6:44am

Patch at #7 works for me. When I manually delete files listed in destinations, the .info files get removed as expected.
B&M 7.x-2.4
Drupal 7.14

#10

Posted by Mile23 on August 8, 2012 at 9:14pm
Status:needs review» reviewed & tested by the community

Marking RTBC, so we can hopefully get some movement on this. :-)

#11

Posted by rodmaz on January 16, 2013 at 12:41pm

Also reporting the same behavior as #2.

#12

Posted by Rory on January 22, 2013 at 3:52am

@rodmaz - are you reporting this before or after applying the patch at #7?

#13

Posted by ronan on February 20, 2013 at 3:23am
Status:reviewed & tested by the community» fixed

This should be fixed in the latest dev. Thanks all.

#14

Posted by Mile23 on February 20, 2013 at 7:51pm

Ossum, thanks.

#15

Posted by System Message on March 6, 2013 at 8:00pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.