This is a great simple module and I'm finding it works really well. It doesn't seem quite finished though.

I'd like to add a few things to this module that are already being tracked in other issues. I'd like for this to work on select widgets, and I'd like to enable it by the field. I can do work on this and submit a patch/patches, but I don't think it makes sense to do it as one big patch.

I think the first thing that needs to be done is to move the form element creation for the add and edit buttons out of _nodeconnect_field_attach_form() and into their own functions. This needs to be done in order to more flexibly add these elements to the form. Doing this change now means that other issues that require altering that form can be looked at independently.

CommentFileSizeAuthor
#5 nodeconnect_abstraction_form_additions-1558574-5.patch4.88 KBdtarc
#4 nodeconnect_abstraction_form_additions-1558574-4.patch4.88 KBdtarc
#2 nodeconnect_abstraction_form_additions-1558574-2.patch4.43 KBdtarc
#1 nodeconnect_abstraction_form_additions-1558574-1.patch4.45 KBdtarc

Comments

dtarc’s picture

dtarc commented
Status: Active » Needs review
StatusFileSize
new nodeconnect_abstraction_form_additions-1558574-1.patch4.45 KB

Here's the patch. It's a very simple patch, hopefully this could be committed soon.

I think this patch will be needed for this module to develop much further.

dtarc’s picture

dtarc commented
StatusFileSize
new nodeconnect_abstraction_form_additions-1558574-2.patch4.43 KB

Rerolling the patch to fix a typo from the first one (variable $extra was erroneously being referred to as $extra_class).

dtarc’s picture

dtarc commented
Status: Needs review » Needs work
dtarc’s picture

dtarc commented
Status: Needs work » Needs review
StatusFileSize
new nodeconnect_abstraction_form_additions-1558574-4.patch4.88 KB

Those last couple patches won't work. I've been trying to break up the patch here - http://drupal.org/node/1341592#comment-5879104 and I was a bit sloppy.

Attached is a patch that moves add and edit form elements to their own functions. It has been tested and seems to work properly.

This should allow the patch in #1341592: Nodeconnect widget should work also with other widgets to be much smaller. I will make the patch in that issue dependent on this one.

I am breaking these up in the hopes that they will get committed sooner. If the maintainers would prefer one big patch I can do that too.

dtarc’s picture

dtarc commented
StatusFileSize
new nodeconnect_abstraction_form_additions-1558574-5.patch4.88 KB

Rerolling this patch with some minor tweaks.