Needs review
Project:
File Ownage
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 May 2012 at 17:23 UTC
Updated:
12 May 2012 at 11:36 UTC
Hi! The 7.x version of file_ownage doesn't work due to a bug on settings management.
One example is the "image_attach_method" setting is loaded on the following array:
$settings['image_ownage']['image_attach_method']
But on the source code it is called with:
$settings['image_attach_method']
Due to the logic applied on the subsettings (I mean the $subform = $subform_func(isset($settings[$method]) ? $settings[$method] : array()); ) this could be quite correct but it doesn't work because the subform values are stored on the sub array.
Comments
Comment #1
dman commentedYeah, the state it was in was unstable.
I'd just gone through and started renaming the variables and placing a few of the settings into sub-arrays, but hadn't completed that for all cases. A bunch of the settings were reading from one var name and writing to another.
I've finished that refactoring now.
should be 80% better.
Comment #2
finex commentedGreat!