Closed (fixed)
Project:
Revisioning
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 May 2012 at 20:11 UTC
Updated:
24 Mar 2016 at 16:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
rdeboerThanks for the patch cangeceiro!
Hope to apply it soon.
Rik
Comment #2
rdeboerThis has dropped of my radar. Sorry. I hope to apply this patch soon.
Rik
Comment #3
rdeboerPatch applied to 6.x-3.x branch (ie 6.x-3.x-dev snapshot).
Thanks cangeceiro !
Rik
Comment #4
rdeboerComment #6
LittleRedHen commentedThe standard router path defined for node/%node is now _revisioning_view (set in revisioning_menu_alter at line 278).
With this patch in place, every time you try to view a particular revision, _revisioning_view will be called instead of revisioning_view_revision. If you happen to have the 'Links to view content default to displaying the latest revision' configuration setting turned on, it will then *always* be the latest revision that gets shown, never the one you asked for.
This breaks the revision list; no matter which revision you select, it is always the latest one that gets shown.
I worked around it by replacing this patched function with my own page-callback that did not include this patch, but it would be nice if the revisioning module handled that scenario correctly.
Comment #7
LittleRedHen commentedAttempting to re-open this issue, because I'm pretty sure it's not quite working the way you'd intend...
Comment #8
rdeboerThanks LittleRedHen,
See what you're saying... Darn why wasn't this picked up by anyone during the 2 weeks that the module was in dev....
Comment #9
rdeboerI've put in a band-aid check for Panels, while thinking of a better solution.
Comment #10
rdeboerNo longer actively maintaining D6. Sorry.
Comment #11
rdeboerComment #12
ruloweb commentedRe opening this issue, and assigning to 7.x.
Panelizer is not working with revisioning, nodes call default node_view callback.
This patch try to solve this, it applies to 7.x-1.9
Thanks!
Comment #13
jantoine commentedThe patch from #12 works with the default node page provided by the page_manager ctools module. Needs some comment cleanup and additional tests wouldn't hurt, so leaving as needs review for now.
Comment #14
damienmckennaRan into this helping someone to get revisions and Page Manager to work together. The patch in #12 seems to work reasonably well. FYI the latest CTools already uses Page Manager to handle the page load if the node_view display is being managed by it.
Comment #15
ruloweb commentedHi,
I created a new version, which uses DRUPAL_ROOT instead of $_SERVER['DOCUMENT_ROOT'] . base_path(). The last one causes a FALTA ERROR when your site is in a subdirectory like www.example.com/site/
Also I did some creanup.
Thanks.
Comment #16
damienmckennaComment #17
sidharth_k commentedThe patch in #15 is a good one. I've tested it.
Thanks @ruloweb
Also note that if you've got Display suite installed, it tries to mess around with revisioning menu entries in its
ds_menu_alter()(Specifically, you should check_ds_menu_alter(). You may need to deal with that depending on your situation.Comment #18
damienmckennaGood to go, imho.
Comment #19
damienmckennaComment #20
damienmckennaComment #22
rdeboerCommitted a version of #12 & #15.
Thanks everyone.
Comment #23
damienmckenna