Problem/Motivation

i18n_field_field_attach_view_alter() currently uses field_read_instance but according to the documentation it's preferable to use field_info_instance since the latter supports caching.

Proposed resolution

Replace field_read_instance by field_info_instance or add documentation why the use of field_read_instance is necessary.

Remaining tasks

Clarifying if the use of field_read_instance is intentionally.

User interface changes

none

API changes

none

CommentFileSizeAuthor
i18n-i18n_fields-use-field_info_instance.patch771 bytesdas-peter

Comments

webflo’s picture

webflo commented
Issue summary: View changes

Fixed field_info_instance link.

webflo’s picture

webflo commented
Status: Needs review » Fixed

This looks good. Its a nice performance enhancement and saves one query per rendered field.

Commit d8cb931 on 7.x-1.x
Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Fixed field_info_instance link.