In order to share the Twitter API library among both 7.x-3.x and 6.x-3.x branches, twitter.lib.api will be moved to Github and Libraries module will be made a dependency and configured to deal with this.

Comments

juampynr’s picture

juampynr commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Issue tags: +needs backport to 6.x

Done.

http://drupalcode.org/project/twitter.git/commitdiff/bd7605d

juampynr’s picture

juampynr commented
Title: Integrate Libraries » Integrate with Libraries API

All of the changes needed at 6.x-3.x completed.

http://drupalcode.org/project/twitter.git/commit/88591ad

Pending to investigate why attempts to Post to Twitter did not work.

juampynr’s picture

juampynr commented

Reverted changes in 7.x-3.x and cherry-picked at 7.x-4.x.

http://drupalcode.org/project/twitter.git/commitdiff/21dc9b7
http://drupalcode.org/project/twitter.git/commitdiff/fa09a2a
http://drupalcode.org/project/twitter.git/commitdiff/b3dea0a

Now doing the same on 6.x-3.x.

juampynr’s picture

juampynr commented
Status: Active » Fixed

Reverted on 6.x-3.x and ported to 6.x-4.x.

http://drupalcode.org/project/twitter.git/commitdiff/5de205a
http://drupalcode.org/project/twitter.git/commitdiff/012519c

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Issue tags: -needs backport to 6.x

Updated install docs and removed Libraries reference to simplify install process there.

@juampy, above and in comment to 21dc9b7 you said this is on your roadmap for 7.x-4.x? If so I'd be keen to hear the advantages you see to splitting the library offsite. I see some disadvantages to hosting twitter.lib.php elsewhere -

  • Additional install/upgrade step for each site (20K+ install base currently)
  • Issues like #1814610: Use proper API URLs can't be handled here. (Github twitter.lib.php is six months / two commits behind.)
  • Adds two additional dependencies (Libraries module, twitter.lib.php)
  • Introduces potential failure points (wrong lib version installed, improper installation, Github outages)

twitter.lib.php contains Drupal specific functions so is unlikely to be re-used by external projects, and AFAIK there are no copyright reasons to move it away. IMO git makes it easy to keep twitter.lib.php updated across branches.

fizk’s picture

fizk commented

I agree with grobot, twitter.lib.php should remain here.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented

Opened separate issue regarding restoring twitter.lib.php - #1853794: Please consider restoring twitter.lib.php to the Twitter module.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Issue summary: View changes

Added link to Libraries module.