opac

Note that this project is sponsored by BibLibre, a french company dedicated to Free Software for libraries. We are well known to be the largest contributor to Koha, a GPL Integrated Library System.

The Drupal-Opac module is tested with Koha as back-end ILS. It should be live soon in a few libraries that are our customers.

Also Note that this module will be presented at the KohaCon12, in Edinburgh, UK, in june : http://wiki.koha-community.org/wiki/KohaCon12_Schedule#Timings (day 3)

welcome,

I see you already fixed some issues of the automated review, to avoid name clashes with other modules, I'd recommend to prefix submodules with opac_. (eg. there already is a module named "marc")
http://ventral.org/pareview/httpgitdrupalorgsandboxalexarnaud1570572git

• php = 5.2 not necessary as d7 requires 5.2 anyway
• Remove version = "7.x-1.x-dev" also from the submodules
• Functions implementing hooks must be documented properly (See coding standarts / doxygen standarts)
• Don't implement hooks that do nothing (eg opac_install())
• Your readme is quite short, you may have a look at the guidelines for in-project documentation

Unfortunately this module is really bad documented, only few of the functions are commented properly and there are nearly no inline comments. To make it easier for other developers to understand and contribute to your code it would be good to enhance this.

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

gone through the http://ventral.org/pachecklist

Basic application Checks: OK
Basic Repository Checks: OK
Licensing Checks :OK
Documentation Checks : OK

http://ventral.org/pareview/httpgitdrupalorgsandboxalexarnaud1570572git

API Review : OK
Documentation : OK

It is not a duplication of any module.
It could be compared to extensible_catalog : but it does not use the same philosophy and design is there to make it both flexible and configurable.
Configuration is quite easy.
It also could be compared to some specific module for OPAC such as Millenium Integration. But since it aims at some independance from any ILS, that module is interesting.

We are currently quite busy with all the project applications and I can only review/approve projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Alex Arnaud, thanks for your contribution! This can be a difficult process sometimes, so I appreciate your patience as well. But I encourage you to push on and keep up the good work.

The only recommendation I have is on accessibility and maintainability, which is to host your documentation on drupal.org so that the community tools for continuing to edit and extend it are also available. I think the Libraries Interest Group would be a good place to find potential users and organizations that may benefit from this project. If you post a writeup there about how you use this and what they can expect by installing it, then that would be a good way to get some good feedback and reviews.

laurenthdl, that's a very helpful review, I appreciate it. Since this is your first review, I would rather wait and get more feedback from other reviewers as well before having this marked as ready to go.

Thanks again to everyone involved here!

Please consider the following suggestions for the opac .module code:
General:
Comment on what each of your function does.

Per line:
1. Unused constant?
2 define("OPAC_CONTENT_TYPE", "biblio_record");

3. Unused constant?
3 define("OPAC_SERVER_ID_FIELD", OPAC_CONTENT_TYPE . "_serverid");

4. Unused constant?
4 define("OPAC_BIBID_FIELD", OPAC_CONTENT_TYPE ."_biblionumber");

5.
5 function opac_node_isbn($isbn) {
156 }
delete this function.

I think that this module is solid to jump into official contrib, they created documentation there http://drupal.org/node/1677586 and the design of the code looks really ok.
I would vote for a go!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.