Thanks to #1314124: [META] Improve installation profile listing on Drupal.org we renamed the taxonomy term on d.o from "Installation profiles" to "Distributions". This broke the hack (introduced at #652566: Support multiple download files per release in release history XML) in project-release-create-history.php that was adding <variant> info to distribution releases, since the code was checking for a term with the name "Installation profiles". Although #1003764: Add an alter hook invoked while generating release-history XML files is a cleaner solution so that this d.o-specific crap doesn't have to live upstream in project, for now, we have to deal with this here.

This bug was first reported in #drush in IRC, and I just searched and didn't see an actual issue open anywhere about it, so I'm opening this here.

Should be a trivial fix.

While we're at it, we should probably grep the rest of Project* and drupalorg_* for "Installation profiles" to make sure there aren't any other similar bugs lurking.

CommentFileSizeAuthor
#2 1571122-2.release-history-variant-for-distros.patch1.58 KBdww

Comments

moshe weitzman’s picture

moshe weitzman commented
Priority: Normal » Major

This is wreaking some havoc for people in drush issue queue, so elevating priority.

dww’s picture

dww
we/he/they
commented
Priority: Major » Normal
Status: Active » Needs review
StatusFileSize
new 1571122-2.release-history-variant-for-distros.patch1.58 KB

Untested, but I think this is what we need. I guess the "Novice" tag didn't come to the rescue here. :/

dww’s picture

dww
we/he/they
commented
Priority: Normal » Major

Sorry, didn't mean to revert the priority.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

Well, thats about as simple as it gets. Thanks.

dww’s picture

dww
we/he/they
commented
Assigned: Unassigned » dww
Status: Reviewed & tested by the community » Fixed

Committed, pushed and deployed. Rebuilding the feeds now. Please reopen if <variant> hasn't properly reappeared in about 15 minutes.

dww’s picture

dww
we/he/they
commented

http://updates.drupal.org/release-history/drupalorg_testing/6.x now has <variant> in there and it all looks sane.

Yay,
-Derek

dww’s picture

dww
we/he/they
commented

In IRC, just got confirmation this is indeed fixed:

[12:47pm] dww: moshe_work, jhedstrom, et al -- can someone confirm that drush is happy again with <variant> in the d.o release history feeds?  I'm not sure what I should try to verify it's working properly, since I wasn't sure exactly what drush commands were failing as a result of the busted feeds.
[12:47pm] moshe_work: dww: will try to check that
[12:47pm] jhedstrom: dww: sure--there was a test failing due to that, so i'll just run those
[12:50pm] dww: jhedstrom, moshe_work: thanks.  sorry for the trouble.  just wanted to clear it out of my mind now that it's deployed. ;)
...
[12:57pm] jhedstrom: dww: all tests are passing now, so i think that's fixed. Thanks!
[12:57pm] dww: jhedstrom: great, thanks!

Yay,
-Derek

Automatically closed -- issue fixed for 2 weeks with no activity.