Panels adds a region class to every region, .panel-panel, and ds 6.x adds .ds-region to each region. This simply allows you to apply identical styles to all printed regions in panels or ds.

7.x-2.x is currently lacking this class. The attached patch adds .ds-group to each printed group in template, in line with the use of .group- class names already in use.

CommentFileSizeAuthor
#1 1573106.patch1014 bytesxtfer

Comments

xtfer’s picture

Assigned: Unassigned » xtfer
Status: Active » Needs review
StatusFileSize
new1014 bytes

Patch attached, and I've also pushed this in a named branch to make it easier to commit.

swentel’s picture

Assigned: xtfer » jyve

Going to assign this to jyve, I don't have any strong opinion on this one.

aspilicious’s picture

Assigned: jyve » Unassigned
Issue summary: View changes

Putting back on top, will ask a themer at the office soon.

aspilicious’s picture

Status: Needs review » Closed (won't fix)

Ok asked the themers and they don't see any benefits. So closing this for now.

xtfer’s picture

That was an easy win, lost to the opinions of a minority...

aspilicious’s picture

Status: Closed (won't fix) » Needs review

Well the reasoning behind this decision is simple. You can already accomplish this by adding the same class to each region in the UI.
Front end geniuses these days don't like unused classes apparently.

But because I appreciate your work I'm going to reopen this again. Maybe I'm missing something?

xtfer’s picture

Status: Needs review » Closed (won't fix)

TBH I never had much hope for this issue, but I appreciate it being reopened.

I honestly think this is useful, it certainly helped on a few builds with doing simple things like applying equal padding to all regions, borders etc. It's also marginally more semantic - currently the group can't be determined from a layout using child elements, since there may be intermediate elements.

However, given its age and the lack of interest, perhaps I am wrong.