Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
12 May 2012 at 09:29 UTC
Updated:
16 Jul 2012 at 13:01 UTC
Do not install this bundle of joy if you do not have to share specific user data from the CAS server to the CAS client.
The sync always happens from the server to the client.
The sync always happens on user login, therefor, a user must logout and then log back in for any changes to take effect if the user was logged in at the time when the changes were made. Have a look at the README.txt for more information
A D6 version of the cas_fields_client module is coming soon.
Both cas_fields_client and cas_fields_server are intended to be used with D7.
Project page : http://drupal.org/sandbox/CristianAndrei/1514360
Git url : http://git.drupal.org/sandbox/CristianAndrei/1514360.git
Comments
Comment #1
Cristian.Andrei commentedComment #2
acobot commentedYou should not working on a master branch, the branch should be 6.x-1.0 or 7.x-1.0, Moving from a master to a major version branch.
Comment #3
operinko commentedComment #4
Cristian.Andrei commentedcreated a 7.x branch, fixed ventral.org/pareview issues and added meaningful text to README.txt. Please review
Comment #4.0
Cristian.Andrei commentedaddded missing project page and git url
Comment #4.1
Cristian.Andrei commentedupdate project description
Comment #4.2
Cristian.Andrei commentedadded review category
Comment #4.3
Cristian.Andrei commentedadded one more review to the list
Comment #4.4
Cristian.Andrei commentededited review category
Comment #5
Cristian.Andrei commented*added "PAReview: review bonus" tag*
Comment #6
klausiRemoving review bonus tag, you have not done any manual review, you just posted the output of an automated review tool. Please take an actual look at the source code of the applications.
Comment #7
Cristian.Andrei commentedHi klausi,
Thanks for pointing that the reviews need to be manual code review and not any other form of review. When reading the [META] Review bonus, I did not see any explicit piece of information that the review should be exclusively code review. I posted a comment on the page mentioned before and, hopefully, the instructions will be updated.
Comment #7.0
Cristian.Andrei commentedchanged review category title
Comment #7.1
Cristian.Andrei commentedadded first "proper" review comment to list
Comment #7.2
Cristian.Andrei commentedadded second "proper" review comment
Comment #8
Cristian.Andrei commented*added "PAReview: review bonus" tag*
Comment #9
klausiThank you for your reviews! When finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no flaws).
There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
manual review:
Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.
Comment #10
Cristian.Andrei commentedThanks for the manual review, klausi.
I've cleared the master branch of any content.
Here are some comments to your manual review :
Comment #11
operinko commentedCouldn't find any more show stopper issues in the code.
Testing went fine, although I think there might be an issue I didn't test.
In cas_fields_server.module line #32:
You're using regular expressions to get hostname from the referer url without the http://, but the same regex won't work with https (no matches).
This, to me, won't stop the project going full (just an idea that might be good to include, it's supposed to be a centralized login system after all).
Comment #12
Cristian.Andrei commentedThanks for the review, operinko.
I changed
preg_match('@^(?:http://)?([^/]+)@i', $service, $matches);to
preg_match('@^(?:http|https://)?([^/]+)@i', $service, $matches);so this scenario is handled properly.
Comment #13
klausimanual review:
Although you should definitively fix those issues they are not hard blockers, so ...
Thanks for your contribution, Cristian Andrei! Welcome to the community of project contributors on drupal.org.
I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.
Thanks to the dedicated reviewer(s) as well.
Comment #14
Cristian.Andrei commentedHi klausi,
Thank you for your comments, I've fixed all of them , except no. 1. I think that for clarity sake I'll leave the implementation the way it is as everything is exposed and no "magic" happens in the background.
cas_fields_server_cas_server_user_attributes() is a custom hook exposed by the CAS module. I've commented the function to make sure that it is clear where that functionality comes from.
Thank you for your effort in reviewing my module.
Comment #15.0
(not verified) commentedadded last "proper" review comment