Per discussion in issue 157255, I recommend that the comment feed for a single node should not be included the comment feed. This patch removes it.

CommentFileSizeAuthor
#2 commentrss_removenode_0.patch4.67 KBtangent
commentrss_removenode.patch3.45 KBtangent

Comments

tangent’s picture

tangent commented

Err...that was poorly worded. The patch removes the node entry from single node comment feeds.

tangent’s picture

tangent commented
StatusFileSize
new commentrss_removenode_0.patch4.67 KB

I noticed a couple of white-space coding style errors in my patch. This patch fixes those and 3 others.

gnassar’s picture

gnassar commented

Sorry, didn't see you'd already filed this issue. I guess if this is already created, then the module creator can just choose between using the patch making the teaser node an option and this one on his own judgement. Saves us bandwidth to discuss other things. :-)

tangent’s picture

tangent commented

No worries, I just created it.

I'm all for letting the module owner accept the patches they want (as you mentioned in the teaser issue) and ignore everyone else. The problem with that is that a community module either needs to use best practices or risk having another module with similar features rise up to compete with it.

As a proponent of standards I would hope to discourage odd implementations like this one, not only on my websites but on others' as well.

gnassar’s picture

gnassar commented

Which is why I think a module that both allows for the standard implementation and the nonstandard, but expected, implementation, makes the most sense.

I don't see how a new contributed module that forces one method of operation adds any intrinsic benefit to a module that gives you either option. Contributing such a module would be against the CVS contrib usage guidelines as per the handbook: http://drupal.org/node/59.

tangent’s picture

tangent commented

I don't see how a new contributed module that forces one method of operation adds any intrinsic benefit to a module that gives you either option. Contributing such a module would be against the CVS contrib usage guidelines as per the handbook: http://drupal.org/node/59.

I apologize if my previous comment came across like I was threatening to fork commentrss if I didn't get my way. I wouldn't be putting so much work into this module if I had even considered that.

tangent’s picture

tangent commented
Status: Needs review » Fixed

I've committed this patch. If there are concerns please re-open this issue and discuss. I think this change is for the best.

tangent’s picture

tangent commented
Status: Fixed » Closed (fixed)