Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.removes "tag" from xml files if not available
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | project-release-history_empty-tag_0.patch | 1.04 KB | hass |
| #3 | project-release-history_empty-tag.patch | 1.02 KB | hass |
| project_release.module-no_tag.patch | 1.03 KB | hass |
Comments
Comment #1
dwwshould be:
Comment #2
hass CreditAttribution: hass commentedi thought about this... but what will happen if someone adds
<hackme>. Then the empty() will not match and check_plain will insert a blank tag again!?Comment #3
hass CreditAttribution: hass commentedpatch changed as requested, but may add a blank tag as stated above.
Comment #4
drewish CreditAttribution: drewish commentedyeah, it does seem like you'd want to do something like:
Comment #5
dwwYup, drewish's version looks good to me.
Comment #6
hass CreditAttribution: hass commentedok, looks much better. patch attached.
Comment #7
dwwCommitted to HEAD, thanks.
BTW, while I was at it, I renamed this script to "project-release-create-history.php" to more closely mirror "project-release-serve-history.php", since "project-release-history.php" was a little ambiguous now that the "serve" script exists. I've already fixed things up on d.o to deal with this rename. Hass, I assume you're install is the only other one on earth, so I figured this was as good a place as any to inform you about the change. ;)
Cheers,
-Derek
Comment #8
hass CreditAttribution: hass commentedYou are only talking about my test install. But let's get the stats collection in production and see :-). thx
Comment #9
dwwStats collection won't tell us anything about this. It'll just say how many sites are using project (not even project vs. project_release), much less how many have deployed project-release-create-history.php.
Comment #10
hass CreditAttribution: hass commentedWell i know, it only gives an idea. From your last post's i thought you are talking about - "nobody" except d.o. is using Project at all. I think many Theme gallery sites may start to using it after D6... just name me "early adopter" :-).
Aside i think i'm the first and only - who implemented a multilingual install profile with autolocale module for D5 yet, too.
Comment #11
dww@hass: If I'm going to take the time to reply to you at all, PLEASE carefully read what I say. My comment about "I assume your install is the only other one on Earth" was specifically about project-release(-create?)-history.php. Of course project* is used by other sites. ;)
Comment #12
(not verified) CreditAttribution: commented