voipcscriptui.module currently has bunch of db queries that needs to be ported to D7 format (see TODOs).

CommentFileSizeAuthor
#5 voipscriptui-1577968-6106590.patch2.61 KBnit3ch

Comments

tamerzg’s picture

tamerzg commented

also l() functions are broken.

tamerzg’s picture

tamerzg commented

In voipscriptui_form_alter query:
SELECT field_voipscriptui_code_value FROM {content_type_voipscriptui} WHERE nid = :nid

must be changed to use new D7 tables.

tamerzg’s picture

tamerzg commented

voipscriptui_scripts_page()
must port D6 changes.

Also in D6 added 2 new parameters to getScriptNames:
getScriptNames($module_id=NULL, $include_info=FALSE)

nit3ch’s picture

nit3ch commented
Assigned: Unassigned » nit3ch
nit3ch’s picture

nit3ch commented
StatusFileSize
new voipscriptui-1577968-6106590.patch2.61 KB

hi,
This patch has following issue solved
1. Changed the DB name : comment #2
2. Hook_acces is replaced by hook_node_access
3. And some coding standard fixes.

tamerzg’s picture

tamerzg commented

I took the db name change from your patch. However there is no need to replace hook_access with hook_node_access, as not all VoIP scripts are nodes.

Also I fixed the l() functions. However there is still some work on voipscriptui_scripts_page(), compare it with D6 version you ll see there is bunch of things missing.

tamerzg’s picture

tamerzg commented

Let me know if you will work on this issue, otherwise I ll take it over.

nit3ch’s picture

nit3ch commented

please go ahead, i working on some other issues. thanks

tamerzg’s picture

tamerzg commented
Assigned: nit3ch » tamerzg
tamerzg’s picture

tamerzg commented
Status: Active » Needs review
tamerzg’s picture

tamerzg commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.