Strict warning: Only variables should be passed by reference in commerce_node_checkout_form_node_form_alter() (line 49 of /path/to/module/commerce_node_checkout/commerce_node_checkout.module).

CommentFileSizeAuthor
#1 commerce_node_checkout.fix_strict_warning.1578804.patch592 bytesfp

Comments

fp’s picture

fp commented
Status: Active » Needs review
StatusFileSize
new commerce_node_checkout.fix_strict_warning.1578804.patch592 bytes

See patch.

michaellenahan’s picture

michaellenahan commented
Status: Needs review » Reviewed & tested by the community

I can confirm that the patch works as expected.

mrburton’s picture

mrburton commented

Had the same issue, and I can also confirm, that this patch works.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: commerce_node_checkout.fix_strict_warning.1578804.patch, failed testing.

The last submitted patch, 1: commerce_node_checkout.fix_strict_warning.1578804.patch, failed testing.

mstef’s picture

mstef commented
Issue summary: View changes
Status: Needs work » Fixed
Related issues: +#2261333: The product selection widget on nodes should be added via the Field API

This has been fixed in: #2261333: The product selection widget on nodes should be added via the Field API

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs review

chipchenko queued 1: commerce_node_checkout.fix_strict_warning.1578804.patch for re-testing.