Provide interfaces for selecting stream wrappers during file upload and converting files between stream wrappers

Marked #1330200: Support for private files and download protection as a duplicate.

Maybe we should also allow users to switch files between any valid stream wrapper.

I am not certain that this is the right approach. This does not yet work properly, but it should give you an idea of where I'm headed with this.

here you go

This fixes the tests I believe.

okay. I figured this out. with some screenshots to boot.

whoops

and again, without the debugging statements.

#11: move-files-scheme-1580820-11.patch queued for re-testing.

Looks like this module is already doing this, or maybe could help you do what you want to do if not exactly the same.
http://drupal.org/project/file_entity_private_upload

It would be nice if non-developers didn't have to know or worry about a "public" or a "private" file system at all.

At the very least, the conversion should be automatic when needed. i.e. if the user wants to make the node private via content access, the attached files should be lazily converted to the managed (misnamed "private" in Drupal) filesystem. If they user wants to assign access controls to a file, they should be able to do that without worrying about file systems.

This is really basic UX stuff.

The more I think about it, files should always be managed. It is way simpler if all file urls are always /site/files/filename on all Drupal sites. The performance issues should be left up to varnish or whatever caching layer. ....but, that's a whole another story

Marked #1928294: Add File (file/add path) does not honor Allowed Streams defined in file type as a duplicate.

Finally got around to doing a review of #11 and it looks great!

I've got a few comments:

• The scheme options are added to the filetype page, making it impossible to select a different scheme if the uploaded file's mimetype matches one of the configured file types (which results in the upload "wizard" skipping that step). I think it would be easiest/most user friendly to simply add a new "scheme" step to the wizard.
• The scheme options don't take the file's filetype's allowed streams into account, so the user can end up selecting a disallowed scheme which, upon submitting the form, results in an error.

I'll try rolling an updated patch.

A patch to address the feedback in #18.

Committed #19 to 7.x-2.x.

This looks good to me. Thanks for the catch.

I just found this issue, wish i found it a month ago. I created this some time ago (see screenshot), so i think it's awesome this functionality is now added to this module, but i do wonder a bit. Does this patch also offers a way to limit the available filesystems on the file type settings page? (and what about permissions via a role based something?)

An updated patch to restrict access to the destination settings if the file is not writeable (the same check that is done when replacing files).

@Rob C, only the allowed streams for the file's file type are selectable.

@Dave Reid, I'm just curious (or likely missing something :P), why limit this to only local files? Wouldn't that limit valid use cases such as moving a file from one remote scheme to another; such as from Amazon S3 to Google Cloud Storage?

Errr ... may I strongly suggest that if admin has set the default storage in the file field settings, and the current user does not have explicit permission to override this, then the user should not be presented with this confusing and potentially dangerous screen.

There is no way I want my users deciding that file fields I have defined as private should be switched to public when they upload a file.

Could we perhaps have a permission to control this?

Have to agree with #32 here. This has introduced a pretty serious UX issue and make uploading files only suitable for people that understand the difference between for example 'Public local files served by the webserver.' or 'Private local files served by Drupal.' - which really only encompasses Drupal developers - just a small fraction of this module's userbase.

Was a follow up issue created for this? I couldn't find one.

I strongly agree with #16 and #32 as well. Whenever a client's site is updated to include this change, I have editors and administrators submitting tons of support tickets and generally freaking out because they are confused by the new option when uploading, or someone tries putting a file in the wrong place.

I honestly can't think of a single client site we have built in the last five years where this option does anything except add confusion and more work. I also don't think this solved the original issue request, which seemed to be asking for a way to convert files from public to private after they had been already on the site.

Please, is there a way to simply limit this choice to certain roles?

Please don't dismiss this as just a rant. I need help finding the best way to remove this upload destination option for our clients. I guess I'll try to downgrade to the unstable version again, and hope that doesn't introduce any other problems. If there is another solution is a different issue, please point me to it, as I was not able to find it.

After making so many good strides towards more user-friendly Drupal, it seems a shame that this poor UX decision has been introduced.

@kkasischke it's a shame that you aren't using File entity's built in configuration options for disabling the "scheme" step of the file upload wizard. ;)

Thank you so much!

The real shame is that I can't buy you a beer. That, and the fact that no one has enough hours in the day to know every module as well as he would like to.

I'm glad there is a place to find experts who can help. Thanks again!

In case someone would be looking for the settings page mentionned in #36, it's right over here: admin/config/media/file-settings.