If the user, after unwittingly deleting the underlying "Gallery collections" , re-enables the module, the settings page will throw a 500 error because the underlying vocabulary object will be null.

The module should create the underlying "Gallery collections" vocabulary on hook_enable, not hook_install.

CommentFileSizeAuthor
#2 1585864_missing-media-gallery-vocab_2.patch6.27 KBjessebeach
#1 1585864_missing-media-gallery-vocab_1.patch6.01 KBjessebeach

Comments

jessebeach’s picture

jessebeach commented
Assigned: Unassigned » jessebeach
Status: Active » Needs review
StatusFileSize
new 1585864_missing-media-gallery-vocab_1.patch6.01 KB

My solution is perhaps a bit dirty. I'm attempting to maintain the integrity of the vocabulary and the default gallery tag in that vocabulary when the Media Gallery module is enabled. I can't come up with a clever way to hide the Gallery collections vocabulary and prevent it from being deleted when the module is installed but disabled.

jessebeach’s picture

jessebeach commented
StatusFileSize
new 1585864_missing-media-gallery-vocab_2.patch6.27 KB

Fix a small issue on site install if this module is included as a required module or if this module is enabled for the first time without any media gallery items present on the site.

ivnish’s picture

ivnish
he/him
commented
Issue summary: View changes
Status: Needs review » Closed (outdated)