The "Email this page" link does not appear on Storylink nodes or teasers on my site. If I have the "show link on main page" setting active, however, it will display the "Email this page" link on Storylink teasers that appear on the main page.

Check out http://www.hordearmy.com/membernews to see what I mean about the Storylink teasers.
Check out http://www.hordearmy.com/comment/reply/1079#comment-form to see a Storylink node (it's actually the post comment node for a Storylink, since there is no real node for this content type).

Also, I checked the Storylink content type to make sure that the forward module is enabled for it (it is, as it is for all my content types...this was automatic when I installed Forward).

Thanks for your help. I'd just like people to be able to forward news stories that haven't been promoted to the main page, since promotion depends on the number of votes each node on my site receives.

Comments

dmetzcher’s picture

dmetzcher commented

This problem goes away if I change the Forward setting for "Form Type" from "link" to "form". So...the link won't appear on Storylink content types, but the collapsable form will work if it is enabled instead of the simple link.

Am I doing something wrong?
I switched to the form type, so at least it will work, but I prefer the link type instead. Is there anything I can do to make it work?

Thanks!

dmetzcher’s picture

dmetzcher commented

I think I've figured this out, and it may be by design...
For teasers, unless they are on the main page (and the option to show the Forward link on main page content is enabled), you will not ever see the "Email this page" link. I see the same thing for video teasers on my site that I see for the Storylink teasers. (See videos here: http://hordearmy.com/video)

So the best way to ask about this issue is this:
Is there any way to enable the "Email this page" link for all teasers on the site, regardless of whether or not they appear on the main page?

Thanks again!

seanr’s picture

seanr
he/him
commented
Title: "Email this page" link does not appear on Storylink nodes or teasers » show link on main worded badly, nodeapi form ignores setting
Component: User interface » Code
Status: Active » Fixed

The problem is a combination of two issues:

First, the "Show link on main" setting in the admin settings form is poorly worded. What the setting actually does is set whether Forward should show on teasers in any list of nodes (homepage, taxonomy/tag list, etc.). I have now renamed it accordingly.

Second, the nodeapi form was ignoring the setting described in the first issue. That issue is also now fixed so both link and form respect that setting.

So, to get this working, download the new version (may need to get from CVS as the auto-packaged release here can be slow to update), then go to the settings page and check the "Show Forward on teasers" option.

dmetzcher’s picture

dmetzcher commented

Sorry, I've never downloaded from CVS before, so I might be doing something wrong. I went to the Forward project page, and clicked the CVS link (http://cvs.drupal.org/viewcvs/drupal/contributions/modules/forward/).

Once there, I downloaded this file:
File | Rev. | Age | Author | Last log entry
forward.module | 1.48 | 37 minutes | seanr | #157023 - Failure notice when sending forward, fix by designerbrent

I uploaded the file into the Forward directory (in the modules directory) on my site.
However, when I went to the settings page for the module, I didn't see anything different. I ran the update script on my site, just to be certain, but nothing has changed on the module's settings page. I also checked the video page for my site (which lists teasers for video nodes, and I don't see the link to email the node). (http://hordearmy.com/video)

Sorry if I'm doing something wrong, or missing something here.

seanr’s picture

seanr
he/him
commented

Try this one:
http://cvs.drupal.org/viewcvs/*checkout*/drupal/contributions/modules/fo...

Right click, save as, upload to your site, then go to http://hordearmy.com/admin/settings/forward reload and check the second checkbox at the top of the settings form (will say "Show Forward on teasers").

dmetzcher’s picture

dmetzcher commented

OOPS
Sorry...ignore my last post. I see the setting now...I uploaded the wrong file. Sorry about that.

So, I see the setting description has changed. I checked the new setting, saved the changes, and went to http://hordearmy.com/video, but I don't see the Forward link on the teasers. I only see it if I click the node title and view a node itself.

Am I doing something wrong?

seanr’s picture

seanr
he/him
commented

Did you try it again with the file I just linked to? That one has another change that should get it to show up.

dmetzcher’s picture

dmetzcher commented

By the way, I'm trying to use the "Link" option, rather than the "Form" option, if that helps.

dmetzcher’s picture

dmetzcher commented

Yup, I'm using the one you linked above.

seanr’s picture

seanr
he/him
commented
Status: Fixed » Active

OK, will continue looking into it.

dmetzcher’s picture

dmetzcher commented

OK, thanks for your help. :-)
I switched to the "Form" type, in the meantime, in case you happen to look at my site or the links that I've referenced above. The "Form" type does appear on the nodes, so I'll just use that one for now.

Thanks again!

seanr’s picture

seanr
he/him
commented

OK, I can't figure out why it wouldn't be working for your site. I've got a page with a tag assigned to it and when I go to that term, the page teaser shows with the link in the links below the teaser. Everything is working as expected. Is the video page a taxonomy term or is that page generated by some module?

dmetzcher’s picture

dmetzcher commented

It's not a taxonomy term. It was generated by another module. (http://hordearmy.com/video)
Also, the one for Storylinks is generated by a view that I created. (http://hordearmy.com/membernews)

Could that be it? If so...why would the "Form" type work, but not the "Link" type?

seanr’s picture

seanr
he/him
commented

The two work totally differently. The form uses hook_nodeapi which actually appends the form to the node's content, whereas the link uses hook_link which adds it to the node's links array. It's possible that the modules are somehow scrapping links added via that hook.

Can you please set it back to use the link and check the views page? I want to know if it's both the video and views modules that are breaking it or just the video module.

dmetzcher’s picture

dmetzcher commented

"I want to know if it's both the video and views modules that are breaking it or just the video module."

It's both...
Video module: http://www.hordearmy.com/video
Custom view: http://www.hordearmy.com/membernews

I created the custom view. It takes all the nodes with a content type of "Storylink" and puts them into a page for members to view the stories submitted by other members.

The video module...I just installed that and it created the page reference above, so I didn't have to create a special view for it.

Thanks!

seanr’s picture

seanr
he/him
commented
Status: Active » Closed (won't fix)

Not sure if this issue is still a problem, but if it is, it should probably be filed against those modules. As far as I can tell, Forward does everything it should correctly.