Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
18 May 2012 at 10:35 UTC
Updated:
15 Dec 2012 at 11:35 UTC
This is module for Drupal 7.
It keeps record of the last node created by user for each content type.
Linked with Views it lets developer show only the last/latest node per each user.
The sandbox project URL is:
http://drupal.org/sandbox/alx_benjamin/1587530
Git: git clone http://git.drupal.org/sandbox/alx_benjamin/1587530.git author_latest_content__alc_
Thank you for the review.
Comments
Comment #1
patrickd commentedwelcome,
As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page. Also create a README.txt that follows the guidelines for in-project documentation.
Also I'm afraid that this project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed (we have to check whether you are able to create secure and correct code). However, we can promote this single project manually to a full project.
while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxalxbenjamin1587530git
We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.
regards
Comment #2
alx_benjamin commentedHi patricks,
thanks for looking at the module.
I've corrected the mistakes you mentioned and ran the repository via PareView.
I understand there is not much in the code so promoting the project manually will do.
I will definitely start looking at other developer's codes asap.
Thanks again.
Alex
Comment #3
patrickd commentedgreat, don't forget to switch back to 'needs review' if your ready :) (see workflow)
Comment #4
alx_benjamin commentedSwitching to 'needs review'.
Comment #5
farhadhf commentedHi Alex,
There are still a few problems left:alc.views.inc: Line 75: the final ?> should be omitted from all code filesalc.install: @file block missingindentation should be 2 spaces, your are using 4 spacesPlease remove every file other than RAEDME.txt in master branch! See step 5 in http://drupal.org/node/1127732 .
The problems I mentioned are fixed in 7.x-1.x branch.
Regards
Comment #6
patrickd commentedPlease only set needs work on major issues, so deeper reviews are not blocked
Comment #7
alx_benjamin commentedI've removed all files and added note to README.txt in master branch as per step 5 in http://drupal.org/node/1127732.
Changing status to 'needs review'.
Comment #8
alx_benjamin commentedGuys,
do I need to do anything else before my project is promoted to a full project or should I just wait?
Comment #9
rrbambrey commentedHi there,
Well I've been over it and over it and I can't see anything that jumps out at me so marking as RTBC.
Comment #10
alx_benjamin commentedThank you very much
Comment #11
klausiWe are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)
Comment #12
patrickd commentedThere is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch:
Don't start every commit message with "-"
read about Commit messages - providing history and credit
As far as I can see the current implementation will only work for new or updated nodes, existing nodes won't be shown in the view because your table is empty. This is quite unhandy for people who want to use this on their existing site.
All information contained in your table is also contained in the node table, why do you even need your own table?
please answer this question, leaving rtbc
Comment #13
patrickd commentedComment #14
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.
Comment #14.0
klausicorrected typo