iOSZoomFix adds ios-orientationchange-fix.js to Drupal which is a script written in
javascript that fixes the Orientation Change Zoom bug found in iOS Devices.

The bug happens when you're using <meta name="viewport" content="width=device-width, initial-scale=1.0, user-scalable=yes">.
If the attribute "user-scalable=no" or if you're not using the meta viewport in your website, then you don't need this module because the bug only happens because of the meta viewport being there.

The project page: http://drupal.org/sandbox/utneon/1590218

git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/utneon/1590218.git ioszoomfix

Version: 7.x-1.x

CommentFileSizeAuthor
#4 ioszoomfix-coder.txt1.67 KBKrisBulman
#4 ioszoomfix-codesniffer.txt2.25 KBKrisBulman

Comments

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Status: Needs review » Needs work

The git download link you have provided is your personal one. This is your proper public git link:
git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/utneon/1590218.git ioszoomfix

README file should be README.txt - see http://drupal.org/node/447604

This plain-text file should contain a basic overview of what the module does and how someone may use it. It should provide enough information for the user to evaluate whether it will suit their needs before they download and install the module.

  • The README.txt file should repeat the synopsis on the project page on Drupal.org.
  • The project page on Drupal.org should contain a direct link to the README.txt.
  • Like all other module files, README.txt and other *.txt files, should use unix-style line-endings (\n), and not windows (\r\n) or mac (\r) line endings.
  • The file should be formatted to hard-wrap at 80 characters with unix-style line-endings.

Implementation of the Libraries API looks correct. Noted the provided /lib/ios-orientationchange-fix.js is a fallback and is eligible for inclusion per the license. I think you should re-word the README.txt to encourage users to use the file in their libraries folder. The way you have it now seems to undermine the system a bit.

Manual review does show a few code style errors. Mostly empty spaces during linebreaks - probably created by your IDE.

README.txt has lines over 80 characters long.

I think the demo link should be for your module, not for the original project's demo. The demo would function to show how the module works in Drupal.

In general, I question the problem-space in having a 1:1 relationship between Drupal modules and popular js libraries. Wouldn't using Javascript Libraries Manager solve the same issue as this module is trying to resolve?

utneon’s picture

utneon commented

Hello brantwynn . Thank you for your quick reply. The IDE I'm using is Komodo IDE. This is the first drupal project i try to build for public contribution, I will fix those small isues you noticed.

As for your last question, Javascript Libraries Manager seems like it would sove the problem, but keep in mind that a lot of people are not aware of that module and simply search in drupal for keywords like "ios zoom fix, ios orientation bug", so the module makes it easy to give users a solution which was my case. I've been working with drupal for about 3 years and I didn't know about Javascript Libraries Manager.

Will fix some issues right now. Thank you

utneon’s picture

utneon commented
Issue summary: View changes

updated info about the bug

utneon’s picture

utneon commented
Issue summary: View changes

Updated project information and installation instructions as well some guidelines.

utneon’s picture

utneon commented
Issue summary: View changes

updated git clone link to the correct one

utneon’s picture

utneon commented
Status: Needs work » Needs review

Updated the code and Readme.txt as well project information. Fixed whitespace and extra linebreaks for better coding standards. Commited the changes to the 7.x-1.x branch of the git repository.

KrisBulman’s picture

KrisBulman commented
Status: Needs review » Needs work
StatusFileSize
new ioszoomfix-codesniffer.txt2.25 KB
new ioszoomfix-coder.txt1.67 KB

I'd love for this to get accepted & promoted to a full project, however there are still a few issues in the 7.x-1.x branch.. you should check out the coder module and codesniffer. I've attached txt files of their output.

PS I wasn't aware of the javascript libraries manager, this would solve a lot of red tape problems we have justifying new modules at the university I work for. Thanks for the link.

utneon’s picture

utneon commented

Thank you for your feedback. I will work on these issues next week! The libraries manager module is great! =)

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

updated bug info