Hello,
thank you for your work.
I've found a problem.
I login to the site to specific page (/miscellanea) and IpLogin work well.
After I enable logout by user, I can logout myself, but after logout, if I try to access to /miscellanea, IpLogin doesn't work.

Can you help me?

CommentFileSizeAuthor
#13 login-logout-fix-lineendings-1592180-13.patch50.5 KBdsdeiz
#8 ip_login_patch_cookie.patch1.08 KBts145nera
#2 ip_login_patch_cookie.patch1.67 KBts145nera

Comments

jim kirkpatrick’s picture

jim kirkpatrick commented
Status: Active » Closed (works as designed)

Hi ts145nera, this is by design.

When you log out IP Login will not log you back in so that users with permission can log in as another account. Otherwise they'd log straight back in again and you'd never be able to log out. If you don't want that, take the permission from that user type.

You can check it's working by trying going to the site in another browser or 'incognito' window.

ts145nera’s picture

ts145nera commented
StatusFileSize
new ip_login_patch_cookie.patch1.67 KB

Hello Jim,
thank you for reply.
I like this approach, but I think that if I would re-login automatically i must close and reopen browser.
So I do this patch. I hope do you like this.

jim kirkpatrick’s picture

jim kirkpatrick commented
Status: Closed (works as designed) » Needs review

Interesting patch... will look at it soon, thanks.

Status: Needs review » Needs work

The last submitted patch, ip_login_patch_cookie.patch, failed testing.

jim kirkpatrick’s picture

jim kirkpatrick commented
Version: 7.x-2.0 » 7.x-2.x-dev
Category: bug » feature
Priority: Major » Normal

Correcting status...

matt v.’s picture

matt v. commented
Status: Needs work » Needs review

#2: ip_login_patch_cookie.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, ip_login_patch_cookie.patch, failed testing.

ts145nera’s picture

ts145nera commented
StatusFileSize
new ip_login_patch_cookie.patch1.08 KB

I've corrected my patch, please re-queue for testing.

jim kirkpatrick’s picture

jim kirkpatrick commented
Status: Needs work » Needs review

@ts145nera -- thanks, but please set the status to 'needs review' to get the patches tested again. See: http://drupal.org/node/332678 and http://drupal.org/patch/submit for best practice.

Status: Needs review » Needs work

The last submitted patch, ip_login_patch_cookie.patch, failed testing.

ts145nera’s picture

ts145nera commented

you're right, sorry
I hope that it's usefull

jim kirkpatrick’s picture

jim kirkpatrick commented

Thanks but I don't have the time to fix your patch -- but do think it has merit.

Again, please read http://drupal.org/patch/submit for best practice and resubmit/review when you've followed those rules and it's fixed.

Thanks for your help.

dsdeiz’s picture

dsdeiz commented
Status: Needs work » Needs review
StatusFileSize
new login-logout-fix-lineendings-1592180-13.patch50.5 KB

Hi, I had time. Looks like there was a problem with line endings from the module. Attached patch.

ts145nera’s picture

ts145nera commented

So the entire module must be update?

amateescu’s picture

amateescu commented
Issue summary: View changes
Status: Needs review » Closed (outdated)

Closing old issues.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.