Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.In the project_issue module is a very problematic string. Are we able to change this into Add issue, please?
$items[] = array(
'path' => 'project/issues/add',
'title' => t('Submit'),
'callback' => 'project_issue_page',
'access' => $access,
'type' => MENU_NORMAL_ITEM,
);
I will try to explain... for e.g. the German translation team named the node "Submit" button "Save" (in German "Speichern"). This will now name the project issue "Submit" link as "Save" and it is difficult to understand what this should mean. Therefor i'd like to rename this link into Add issue.
Patch attached.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | submit-to-create-4.7.patch | 2.64 KB | bdragon |
| #11 | submit-to-create-4.7-2.patch | 2.62 KB | bdragon |
| #8 | submit_to_create_0.patch | 2.27 KB | hass |
| #7 | submit_to_create.patch | 2.03 KB | hass |
| #1 | add_issue_0.patch | 2.04 KB | hass |
Comments
Comment #1
hass commentedI missed some strings :-(.
Comment #2
dwwSorry, I don't think that's a reasonable change. Look on drupal.org:
http://drupal.org/project/issues
Look at the navigation menu:
It'd be silly to have "Add issue" instead of "Submit" under a menu item called "Issues".
Similarly, look at the links at the top of the page, just under the "Issues for all projects" title. Again, it's *obvious* we're talking about issues here, so "Submit" makes the most sense.
It's not really my fault if the German translation decided to call "submit" the equivalent of "save" instead of "submit". :(
Comment #3
hass commentedYou understand that i'm unable to workaround? Until we get a solution to use the same strings with different translations in different modules. Aside, there is no appropriate word in German for "Submit". If i translate this - it will end in something like "transfer". Other translations will have the same problem. "Add issue" is much more readable / understandable then "Submit" only. Today i need to think "where i'am", ah "issues", ok, "could be - add issue". I know others have renamed in such cases to make it unique. "Add" could be another possible solution for German, i'm not sure if this works for other languages.
I reopen this for now to get a solution for this today unsolvable problem.
Comment #4
kkaefer commenteddww, hass is right: There is no sane translation for "Submit" in the German languages. All available work except for "Speichern" (= Save) are odd or archaic in almost all cases. That's why I submitted the patch http://drupal.org/node/100641 some time ago, but unfortunately it's not yet in. Also see http://drupal.org/node/100636.
Comment #5
kkaefer commentedMaybe this can be changed into "Create".
Comment #6
dwwLooks like #100641 just landed, lucky for y'all... ;)
I guess I can live with "Create" as the menu item and links, since "Create [an issue]" and "Submit [an issue]" are basically equivalent to my native English ears. So, if someone wants to re-roll for changing the links, I'll review and commit.
However, please do not start changing all the "Submit" buttons in project* to "Save" until after the D6 port.
Comment #7
hass commentedRe-roled with "Create".
However i think some strings could be named "Create issue" (for e.g. the one displayed next to "Add release" as an example).
Comment #8
hass commentedmissing help texts added.
Comment #9
JirkaRybka commentedThe same for Czech and other languages around here, in some cases the translation needs to be more specific, or a general word is missing. I have similar problem with "Submit" on Views' exposed filters (means "Search" in fact, nothing to do with "Create" - subpart of my issue http://drupal.org/node/156130 ).
So my point is, that this is a quite common problem in many modules, which should be given more attention generally.
Comment #10
dwwCommitted patch from #7 to HEAD, and regenerated project_issue.pot.
Patch doesn't apply at all on either DRUPAL-4-7 or DRUPAL-4-7--2, but needs to be backported to both branches. Please supply another patch (probably the same would apply on both 4-7(--2?) branches.
Thanks,
-Derek
Comment #11
bdragon commentedHere's your backports, just cuz I felt like it...
DRUPAL-4-7--2
Comment #12
bdragon commentedand DRUPAL-4-7.
Comment #13
dwwThanks, bdragon! Committed to DRUPAL-4-7--2 and DRUPAL-4-7.
Comment #14
(not verified) commented