Closed (fixed)
Project:
Mailhandler
Version:
master
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
16 Jul 2007 at 21:25 UTC
Updated:
23 Aug 2008 at 12:03 UTC
Jump to comment: Most recent file
Comments
Comment #1
elioshI Agree.
It'll be very nice to configure a basic vocabulary, and than add terms to it
Comment #2
moshe weitzman commentedYou could write a module which parsed information out of the subject or body and created/affiliated tags accordingly. after that, we'll see how clean and how popular it is and consider adding to mailhandler itself.
Comment #3
moshe weitzman commentedthis would be possible if we enhance the Commands syntax as per my suggestion at http://drupal.org/node/136606
Comment #4
z.stolar commentedI'm looking into this issue, trying to see if I can create the necessary patch for free tagging support in mailhandler.
Does anyone know of any progress in this direction in the last few months?
Comment #5
z.stolar commentedThe attached patch allows mailhandler to receive tags from free tagging vocabularies.
In order to do that, use the following commands:
* The usual, add regular, EXISTING terms, from whatever vocabulary:
taxonomy: [term1, term2]
* In order to add tags from free tagging vocabularies, use an array-like format, where the key is the VID of the free tagging vocabulary:
taxonomy[4]: [existing term1, existing term2, totally new term3]
The later should work for non free tagging vocabularies as well
Comment #6
moshe weitzman commentedThanks. Could you add some documentation to the Commands section of the help? Also, I really prefer to commit to D6 at the same time. Please consider making patch for it. Some functions have moved around.
Thanks.
Comment #7
z.stolar commentedI will add the documentation, and have a look at the D6 version, but I wanted first to get some feedback on the path I chose.
Mainly, I'd like to know if the format looks reasonable (...usable). Currently a user needs to know the vocabulary id, in order to add terms to it. Does anyone have suggestions for a better format?
For ease of use, I thought maybe have only up to two taxonomy commands:
taxonomy[terms]: which will be equal to the current taxonomy: command
and
taxonomy[tags] (or [new tags] or [freetags]...) which will add any new terms to the first free tagging vocabulary for that node type.
While this limits the possibilities, it may ease the use of the module for those who don't know the vocabulary id (which is probably true in most cases)
Comment #8
moshe weitzman commentedAt first read, I like your proposal in the patch the best.
Comment #9
gaele commentedz.stolar, thanks for this patch.
Although vocabulary id may not be the easiest way for users, it is the cleanest way. I like that.
Comment #10
z.stolar commented@Moshe: there was no Commands section on the help page, so I added one :-)
This patch includes the same addition of free-tagging in mailhandler, and adds a section to the help page of mailhandler.
Currently listed are only the taxonomy commands, but there's a nice associative array, that facilitates the addition of more commands, and their description.
It is done like this (in hook_help):
Comment #11
z.stolar commentedAnd here's a corresponding patch for Drupal 6 (I'd put HEAD in the version tag, but I read somewhere the project hasn't got a HEAD branch).
Comment #12
z.stolar commentedI fixed both my earlier patches, due to some errors I just found.
Attached are two patches - one for D5, and one for D6.
Comment #13
moshe weitzman commentedI am getting failed hunks with these patches ... Looks like some of the Command docs which used to be in the module now live at http://drupal.org/handbook/modules/mailhandler/. I have no strong feeling about where they should be.
Comment #14
z.stolar commentedI rerolled the patches, and tested them - they seem to apply cleanly now (I took out some lines).
Please test.
Attached are two patches, for D5 and D6
Comment #15
moshe weitzman commentedCommitted with just a code review. Would be great if folks could test this.
Comment #16
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.