unless i'm missing something:

menu items are cached per user, so the entire admin/project/* tree should be cachable in this module.

i would think that would be some kind of performance boost for d.o, no?

CommentFileSizeAuthor
#1 cvs_menu_cache.patch.txt5.33 KBdww

Comments

dww’s picture

dww
we/he/they
commented
Assigned: Unassigned » dww
Status: Active » Needs review
StatusFileSize
new cvs_menu_cache.patch.txt5.33 KB

Yup, good catch. Since nearly all of the menu items are static and are now in the same code block, I also added an $admin_access variable for clarity. Tested locally, and all appears well. But, a review would be nice before I commit it. ;) Thanks!

hunmonk’s picture

hunmonk commented
Status: Needs review » Reviewed & tested by the community

code looks good. tests out on postgres.

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Was going to backport to DRUPAL-4-7--2 and DRUPAL-4-7 and discovered that the menu items were correctly defined there. ;) Looks like this was a bug introduced in the port to D5 that somehow slipped past me. Oh well. I did backport the $admin_access stuff for additional clarity, though.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)