Posted by davidwhthomas on June 1, 2012 at 10:13am
3 followers
| Project: | Simplenews |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
The attached patch provides two new actions to simplenews_rules
- simplenews_rules_action_subscription_delete ( Delete a subscriber from a selected newsletter )
- simplenews_rules_action_subscriber_delete ( Delete a subscriber from all newsletters )
Thanks,
DT
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| simplenews-rules-delete-subscription-action.patch | 2.32 KB | Idle | PASSED: [[SimpleTest]]: [MySQL] 1,628 pass(es). | View details |
Comments
#1
Looks ok to me, one small coding style issue below. Wondering if we want to reference the unsubscribe action somehow in the description, stating that you should only use delete if you really want that information to be gone completely, or something like that.
+++ b/simplenews_rules/simplenews_rules.rules.incundefined@@ -109,6 +109,34 @@ function simplenews_rules_rules_action_info() {
+ 'label' => t('Delete an e-mail address from a newsletter'),
+ 'group' => t('Simplenews'), 'named parameter' => TRUE,
The named parameter part should be on a separate line.
Same for the one below.
#2
Thanks Berdir,
I noticed the named parameter on the same line for the other existing actions, so just kept that format, in case was for a reason.
I'll make some adjustments and post an update.
#3
Wasn't aware that the existing rules were wrong as well. You're welcome to fix that as well while you're at it.
#4
Thanks Berdir, there's the updated patch.
#5
Thanks, commited and pushed!
#6
Automatically closed -- issue fixed for 2 weeks with no activity.