Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
theme
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
5 Jun 2012 at 06:34 UTC
Updated:
3 Nov 2012 at 13:44 UTC
Product Information
Speakers: 3
Colors: White, Blue
Version of the CMS: 5,6
Raspolozhenie: Fixed
Width: 900px Fixed
Browsers: Mozilla Firefox, Internet Explorer, Opera, Chrome
Files: JPG images, CSS files, JS files, PHP files
Download Drupal Template
| Comment | File | Size | Author |
|---|---|---|---|
| Airhome.zip | 297.05 KB | Vladuslavh |
Comments
Comment #1
D4Ko commentedPlease read: Applying for permission to create full projects and Git documentation
Regards DaKo
Comment #2
ANDiTKO commentedHello Vladuslavh and welcome to the Drupal Community!
Seems like you generated this theme using the program Artisteer.
The good thing about using this tool is that you can make a theme and export it to various CMS and formats. The bad thing is that the themes are usually ugly and poorly coded.
After i did manual inspection of your code i noticed that you don't follow the drupal coding standards.
Your ReadMe.txt file must be renamed to README.txt and written in English. Currently is in Russian.
Another thing is that your theme uses a lot of images. That makes the page loading slow. Most of your images can be replaced with css3 code and the rest combined into css sprites. Aways try to avoid the use of images into a theme. Not only you are making the page size bigger but you add HTTP request that slow the whole loading process.
I wont get into deep code review of your current project because it was generated by Artisteer and not written by you. The whole idea of click and magicly create a theme is wrong. I suggest you use a Drupal theme framework or code your own theme from scratch using the Drupal code standards. Have a look on these frameworks that might help you create your theme faster and cleaner:
Also please check out the Develop for Drupal and Project application checklist pages.
I hope my review don't offend your work, and i wish you the best!
- ANDiTKO
Comment #3
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.