Download & Extend
Feeds » Issues

Update default views (fixes "Missing text format: 1." in watchdog)

Posted by Alan D. on June 7, 2012 at 3:28am
Project:Feeds
Version:7.x-2.x-dev
Component:Code
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I'm not sure if you want to customise the exports, but not all installations have filter format of ID 1.

<?php
-  $handler->display->display_options['empty']['area']['format'] = '1';-
+ $handler->display->display_options['empty']['area']['format'] = variable_get('filter_default_format', 1);
?>
Login or register to post comments

Comments

#1

Posted by Cottser on July 17, 2012 at 3:19pm
Title:Default view relies on a text format with ID 1 (views/feeds.views_default.inc)» Update default views (fixes "Missing text format: 1." in watchdog)

Format IDs are no longer numeric in Drupal 7 (#934050: Change format into string). I think the default views should be updated anyway since Views is no longer in alpha - arguments are contextual filters now, for example. I re-exported the default views (running Views 7.x-3.3), and removed the text format of 1 from the revised export (Views can figure out the format). I didn't do any other massaging of the exported view other than adding a human name of "Feeds log".

This export also adds items to the $translatables array, that seems to be new as well.

AttachmentSizeStatusTest resultOperations
feeds-1620110-1.patch15.12 KBIgnored: Check issue status.NoneNone

#2

Posted by Cottser on July 17, 2012 at 3:22pm

Actually, without this change, the empty text is not displayed at all when visiting node/%/log - so it's not just a watchdog error.

#3

Posted by morningtime on November 23, 2012 at 2:15pm
Status:needs review» reviewed & tested by the community

Patch makes sense.

Do we also need a .install file update_N() routine to update the views?

#4

Posted by JvE on December 17, 2012 at 4:21pm
Status:reviewed & tested by the community» needs review

The $translatables is a Features thing, not a views export thing.

There are some other changes between views-3.0-alpha1 and views-3.0. If we're changing the version, I think we should take those along as well.
If you take the current feeds_log view and open/save every item/setting and then export the view, it shows a couple more differences.

AttachmentSizeStatusTest resultOperations
feeds-default_view-1620110-4.patch21.73 KBIgnored: Check issue status.NoneNone

#5

Posted by Cottser on December 19, 2012 at 2:48am
Status:needs review» reviewed & tested by the community

Thanks @JvE. The patch looks good, I tested it using the minimal install profile.

  1. Enable Feeds UI, Views UI, and all dependencies.
  2. Create a standalone Feeds importer.
  3. Navigate to the “Log” tab of the Feeds importer you just created.

Without the patch, no empty text is shown and a watchdog error is logged. After applying the patch and clearing the cache, the empty text is shown and there are no watchdog errors.

Before:
feeds_default_views_no_empty_text.png

After:
feeds_default_views_empty_text.png

AttachmentSizeStatusTest resultOperations
feeds_default_views_empty_text.png11.87 KBIgnored: Check issue status.NoneNone
feeds_default_views_no_empty_text.png10.67 KBIgnored: Check issue status.NoneNone

#6

Posted by twistor on January 18, 2013 at 12:08am
Status:reviewed & tested by the community» fixed

http://drupalcode.org/project/feeds.git/commit/3cf2de4

#7

Posted by System Message on February 1, 2013 at 12:10am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here