[D7] JQuery Vegas

Welcome.

No coding issues ! well done.

Manual review

I think the module is very well written. I spot the following ones :

1) vegas.install
Your using variables (vegas_slideshow_effect_delay) -> you got to remove them on hook_uninstall with variable_del()
2)vegas.admin.inc
I would advice to not use drupal_add_js() in vegas_admin_settings but use $form['#attached'] instead.
See api.drupal.org/api/drupal/developer--topics--forms_api_reference.html/7#attached
3)vegas.admin.inc
you could use db_delete() instead of db_query() on line 280
4)vegas.admin.inc
$file->status = 1 should be $file->status = FILE_STATUS_PERMANENT;

We do really need more hands in the application queue and highly recommend to get a review bonus so we will(/can) come back to your application sooner.

remove empty li tag

Manual review:
What's the difference with modules which provides similar features:

1. BackgroundField
2. Backstretch?
3. Would you consider merging your project into them?

Manual Review:

1) Use t() function for all strings in vegas_admin_settings() function. Please check all your strings.
2) Doc block are wrong, vegas_admin_settings() this is a form builder function. See http://drupal.org/node/1354#forms. Please check all your function documentation.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

I think it's a little harsh just pointing out two things, settings needs work and removing the review bonus tag..
Please do a more detailed manual review or - if there are no more major points than these - set rtbc instead of needs work

manual review:

1. Remove the hidden *.swp and *.swo swap files from your repository, see http://drupalcode.org/sandbox/iqbalnurhakim/1623992.git/tree/refs/heads/...
2. vegas_get_path(): module_exists() is useless here, as you depend on the libraries module already. It will always be there, you can rely on that.
3. vegas_admin_settings(): why do you need #value on the path setting and cannot assign that to #default_value?
4. "t('<h3>Filename:</h3>!filename', array('!filename' => $file->filename))": you should use the "@" placeholder here instead of "!" and it will sanitize the filename automatically for you.
5. vegas_admin_settings_submit(): why do you need to access the raw form input and cannot use the prepared $form_state['values']?
6. vegas_admin_settings_submit(): use drupal_write_record() instead of db_insert() and you get DB schema validation for free.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Installed the module on a fresh Drupal 7.14 with default Bartik theme. Downloaded, installed and activated vegas module. The Vegas libaries path is "sites/all/libraries/jaysalvat-vegas-51b8166". Selected "use overlay" and "use slideshow". Uploaded 5 background images and saved configuration. However i still do not see the background images although i can see the script being loaded under firebug. Wondering what went wrong? Appreciate if somebody can provide some kind assistance. Thank you.

Solved. Removed the background info under page wrapper element in layout.css. Fullscreen background slideshow is working now.

I am using the latest version of drupal and the default bartik theme and I was not able to get the functionality to work.

edited to add: it seems the problem is a z-index problem, the image slideshow seems to be loading below the z-index of the body.

Also, here are my suggestions:

1. add to installation instructions, the instruction to move downloaded library to libraries/vegas
$ mv jaysalvat-vegas-51b8166 vegas

2. Add instructions on how to add to web pages. I installed the module, downloaded the library and uploaded images, but I have no idea how to actually add the vegas backgrounds to a web page. It seems that this is perhaps an issue with the default bartik theme. I see that @han_k_s had this same issue, but I could not understand how he fixed it.

3. Add code to vegas.admin.inc that adds current configuration options to configuration form. I added the vegas library location and successfully saved configuration, but when I return to admin form the current configuration does not appear, all of the options are blank. My uploaded background images are showing up on the form, but the library location and the checkbox next to overlay and the texture I selected are not showing on the form. Its frustrating as a user to have to re-enter all of the configuration options each time you want to change the configuration.

Thanks,
Bart Lantz

I was able to get the Vegas functionality to work with bartik, the default theme, by adding the following css.

vegas.css:

body > img.vegas-background {
  z-index: 0 !important;
}

and adding the css to the .info file:
vegas.info:

stylesheets[all][] = vegas.css

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

Like the module itself? It's probably me but I can't see any module of any kind. I've tried downloading from git but all I get is an empty readme file. Is this dead?

This project application is closed. Please post all support requests to the module's issue queue: http://drupal.org/project/issues/1623992?categories=All

added revieew of other project

Hey buddy, nice project! Can anybody help me on this issue, I have installed Vegas background and it works perfectly but only in my administration pages, I can see the background images that I uploaded changing, but when I'm on the front page they won't appear. I double checked the permissions in all vegas images and JS folders and they seems to be fine with (755) and already installed bootstrap, jquery and libraries module, don't know what I'm missing, the gif loader appears in the top left corner of the page but the image won't. Any help would be nice, thanks!

#21: Since there is a project in this namespace covering exactly that feature set for D7 and 8 (vegas), I would recommend to set this issue Closed (duplicate) and to inform the sandbox project maintainer and ask for merging forces.

Contrib module link: http://www.drupal.org/project/vegas

Closed (duplicate) means the user has two applications open at the same time. We don't use that status to mean there is already a module with the same purpose.

Also, duplication is not an application stopper.

to #27: yep agreed. never mind - it was just a recommendation in a rush, aaaand ..... it was the wrong issue queue! :) sry

Also, duplication is not an application stopper.

I know ;-)