I am applying for full project status for my module called Contact Info. This is a Drupal 7 module which does one thing: collects contact information for the site and displays it in a block using the hCard format. This is a simple and straightforward way for sites to provide contact information on their site, and to allow users to edit this information without fussing with markup and microformats. Inspired by the Drupal 6 module “hCard” (http://drupal.org/project/hcard), this module is targeted to smaller websites which require a simple and lightweight solution and do not require a more general hCard formatting solution.

This is my first project application and look forward to reading your feedback.

Comments

DavidS’s picture

DavidS commented
Status: Needs review » Needs work

For starters I ran your project through ventral's online PAReview code checker. You can see results here.
http://ventral.org/pareview/httpgitdrupalorgsandboxdboulet1146162git

Also you're doing your work on the master branch rather than a version-specific branch. Here are some instructions on making the move.

Also please improve description of you project by adding missing data (please read more here)

Please, fix these issues, and I will proceed with manual review.

DavidS’s picture

DavidS commented

Here is my manual review:

  1. Don't use \' in t() function (see contactinfo.modules lines 18 and 321).
  2. in forms value for #description should be placed in t() - see lines 255, 267 etc
  3. Maybe instead of t('Your first name (!class).', array('!class' => 'given-name') you may use t('Your first name (%class).', array('%class' => 'given-name') (see comments in format_string() for more info)
  4. On line 236 '#title' => t('Use site name', array('%name' => variable_get('site_name', ''))), I think you missed %name in string
  5. lines 325-336
    // Use ctools for form item dependencies.
  if (function_exists('ctools_include')) {
    ctools_include('dependent');
    $form['contactinfo']['fn_n']['#process'] = array('ctools_dependent_process');
    $form['contactinfo']['fn_n']['#input'] = TRUE; // Force #process to run.
    $form['contactinfo']['fn_n']['#dependency'] = array('radio:contactinfo[type]' => array('personal'));
    $form['contactinfo']['fn_n']['#prefix'] = '<div id="edit-hcard-fn-n-wrapper">';
    $form['contactinfo']['fn_n']['#suffix'] = '</div>';
  }

    I think you can use FAPI attribute #states. For more info see documentation.

dboulet’s picture

dboulet commented
Status: Needs work » Needs review

Thanks very much for the pointers One Hour Translation. I’ve just pushed a few more commits today that address the issues that you mentioned.

There are also no longer any warnings from the PAReview code checker:
http://ventral.org/pareview/httpgitdrupalorgsandboxdboulet1146162git

DavidS’s picture

DavidS commented

OK, nice :)

Also, as I understand, functionality of contactinfo.js can be replaced with the same #states.

And after that, I'm happy to set RTBC status.

dboulet’s picture

dboulet commented

I’m not sure that I could replace the entire JavaScript file by using #states. I could use it to make the text boxes disabled when the checkboxes are checked, but there doesn’t appear to be a way to change the value of the text boxes.

DavidS’s picture

DavidS commented
Status: Needs review » Reviewed & tested by the community

Ok, thanks, I understood.

So, I don't have comments anymore.

But you don't have bonus reviews yet. I think you should do that.

sreynen’s picture

sreynen commented
Status: Reviewed & tested by the community » Fixed

Hi dboulet,

Thanks for your contribution and welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects, at your discretion.

Now that you've experienced the full review process, please consider reviewing other projects that are still awaiting review. Anyone can help with reviews, following the guidelines.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Adding Git repository clone code and specifying Drupal version.