Unactivated User

I think what you mean to say is Inactive User, and you should probably check out this module maintained by Crell http://drupal.org/project/inactive_user which has more of the same kind of functionality if I'm not mistaken.

Perhaps it would be better if you contributed to this module to help get a 7 release out the door? (not far off by the looks of it)

Running coder on your module returns the following:

unactivated_user.module

Line 130: Arrays should be formatted with a space separating each element and assignment operator
    '#default_value'=> variable_get('unactivated_user_mail_reminder_subject', '[site:name]: Unactivated account [user:name]'),
Line 183: Use ANSI standard <> instead of !=
  $query = db_query('SELECT uid,login,created FROM {users} WHERE uid != 0 AND login = 0 AND created <= unix_timestamp(now() - interval ' . variable_get('unactivated_user_reminder_days', 15) . ' day)');
Line 189: Use ANSI standard <> instead of !=
  $query = db_query('SELECT uid,login,created FROM {users} WHERE uid != 0 AND login = 0 AND created <= unix_timestamp(now() - interval ' . variable_get('unactivated_user_delete_days', 30) . ' day)');

Hi,

Please take a moment to make your README.txt follow the guidelines for in-project documentation and make it more informative (How I install the module, What is required ...).

For the uninstall process, you should use the variable_del() function. Even with several variables. Because the variable_del() function does a bit more.

unactivated_user.module

• I believe that the @file comment containsa duplicate comment.
• Line 181 and more: Please use query placeholders to handle values in queries. http://drupal.org/node/310072

Regards, Christian

I notice you haven't addressed the comment on the module with nearly identical functionality http://drupal.org/project/inactive_user

Have you thought of assisting this module get a D7 release instead of releasing this one?

Although the inactive user module does the same thing (when there is a D7 release), this unactivated user module is slick and clean.
Currently using it on a live site to remove user accounts which were made as an invitation/demo possibility.
Just removing the unactivated users is enough for me.

@ thyssimonis
please do not bump issues, this won't help at all
if you want a review bonus it's not enough to just add the reviews to your summary, you have to add the "PAReview: review bonus" tag to this issue!

Removing review bonus tag, 2 of your reviews where only pointers to automated review reports. Make sure to actually read through the source code of other modules and report issues that you find. Then replace those review comments in your issue summary.

Hi,

I am not sure about the /tpl/mail_reminder.tpl file. It seems that the PARreview automated test doesn't check it.

• It lacks comments (a @file block)
• Why it is not a tpl.php file? (like http://drupalcode.org/project/webform.git/blob/refs/heads/7.x-3.x:/templ...)

And although I am not a native english speaker "The number of days when ...." seems somehow unnatural here. Shouldn't this be something like "The number of days after ...."? But you should probably get a second opinion on that :)

Updating status.

You did not point out any major issues -> needs review

Added coder review

make 7.x default branch http://drupal.org/node/1659588

module working fine

"Unactivated" is a bit of strange term. "Blocked" or "Inactive" are more common.
Also the name not really indicates the functionality.
"Unactivated User" - so and what does it do with these "unactivated" users?! - maybe "Inactive user notification" is a much better name here,

If you then try 30 seconds of searching for a similar module you'll get : http://drupal.org/project/inactive_user
Which seems like it pretty much does the same as your module, but it also seems like they need help with their 7.x version.

We prefer collaboration over competition, therefore we want to prevent having duplicating modules on drupal.org. If the differences between these modules are not too fundamental for patching the existing one, we would love to see you joining forces and concentrate all power on enhancing one module. (If the existing module is abandoned, please think about taking it over).

Added a new review