Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
14 Jun 2012 at 21:08 UTC
Updated:
4 Jan 2014 at 02:05 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
DavidS commentedI like the idea of your project!
Why you didn't added this option under the Title field on the Content tab? Mabe it will be more comfortable and user-friendly to have it there instead of new step.
Also make sure your README.txt follows the guidelines for in-project documentation. Your readme may follow the contents of your project page.
Also, maybe you want to delete commented dsm() on line 111
Comment #2
rogical commentedManual review:
--------------------------------
Auto review with http://ventral.org/pareview
-----------------------------------------------------------
see the result.txt
Comment #3
abhishek.kumar commented@One Hour Translation: Sure i will look on your suggestion.
@rogical: I will work on the issues reported by you but i am not getting how i can implement this as a patch can you suggest a way to get it.
Comment #4
rogical commentedFirst, your contribution is a nice work, but as panels already have title settings, I think it should be better to enhance it while not let users to install another module for this, Do you think so? For better User experience.
Second, I think we can alter form 'panels_edit_display_settings_form' to do this, I suggest you can create an feature issue in panles and users would join testing.
Third, there's many other topics can be done to module, if you still want to contribute, there're lots of chance.
BTW, you can get patching guides on every project version control tab: http://drupal.org/project/panels/git-instructions
Comment #5
fotuzlab commentedI support a separate module for a reason that it is not the functionality that everyone would want. In case, it draws too many users, it can be incorporated in panels later. But for now a separate module is what I'll go for.
@abhishek, there are a few minor issues I found.
1. master branch has .info file. It should not have any file other than the README.txt
2. Replace "Implement hook_" in comments by "Implements hook_"
3. On line 61 panel_variant_page_title, description is commented. Either un-comment it or remove it.
Also, I agree with rogical that hook_form_alter can be used here. It would be cleaner implementation IMHO.
Comment #6
fotuzlab commentedAlso there are formatting issues pending as attached in #2
Marking the issue to "Needs work"
Comment #7
patrickd commentedformatting issues are not major - don't block further reviews
Comment #8
abhishek.kumar commented@rogical @fotuzlab :
It's easily manageable by using hook_page_manager_variant_operations_alter and deal with the ctools conf object as well as i have not putted it at below the title because i am planing to provide the text area so that user can also use php code to set the varient page title.
Comment #9
abhishek.kumar commented@fituzlab i have fixed the issues you have reported in point 1,2 and 3.
Comment #9.0
abhishek.kumar commentedAdded details description.
Comment #10
fotuzlab commentedLooks good to me.
Changing the status to RTBC.
Here are some Tips for a great project page.
Comment #11
patrickd commentedYour project page is not very detailed, please have a look at the tips for a great project page, you may also use HTML-tags for better structure. Also make sure your README.txt follows the guidelines for in-project documentation.
There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588
Remove master branch:
Remove "version" and "project" from the info file, it will be added by drupal.org packaging automatically. Also you set "core" twice, remove that.
An automated review of your project has still found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.
http://ventral.org/pareview/httpgitdrupalorgsandboxabhishekkukku1635574git
t('@identifier: @title'...There's nothing to translate in this string, use format_string() instead.
Some more inline documentation wouldn't be bad, help other developers to understand your code without the need to understand every line of code.
Unfortunately project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed (regarding your skills in security and API best practices). However, we can promote this single project manually to a full project.
Comment #12
abhishek.kumar commented@patrickd : I have fixed all the issues reported by you.
Comment #13
fotuzlab commentedI can see a few warnings at http://ventral.org/pareview/httpgitdrupalorgsandboxabhishekkukku1635574git
Changing the status to RTBC (again :) ).
Comment #14
fotuzlab commentedI can see a few warnings at http://ventral.org/pareview/httpgitdrupalorgsandboxabhishekkukku1635574git
Changing the status to RTBC (again :) ).
Comment #15
klausiWe are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)
Comment #16
tim.plunkettI've promoted this project.
http://drupal.org/project/panel_variant_page_title
Comment #17.0
(not verified) commentedAdded git link