The current code in project module allows project/X alias that could break project_issues.module or project.module.

Attached patch tries to be more thorough in preventing this.

CommentFileSizeAuthor
#1 proj_name_blacklist_2.patch1.57 KBdww
proj_name_blacklist_1.patch1.57 KBpwolanin

Comments

dww’s picture

dww
we/he/they
commented
StatusFileSize
new proj_name_blacklist_2.patch1.57 KB

Good catch. However, this taxonomy checking is over-agressive. You're excluding all possible project-related terms, even the module categories. This is bad, since A) some module categories are valid project names and B) project/[module_category] links are never used.

New patch that fixes this (tiny change). Otherwise, looks good [sic] given the insane handling of menu paths in project*. :(

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

After more review and a little testing, committed to HEAD. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)