Closed (duplicate)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 Jun 2012 at 11:50 UTC
Updated:
10 Sep 2018 at 08:19 UTC
Jump to comment: Most recent
Comments
Comment #1
KrisBulman commentedThis is another great module, I'm always looking to add classes to webform components. IMO this should be in the webform module, it's the missing feature. Have you created an issue on adding this?
Are there plans to add the ability for multiple classes?
This review is for the 7 branch only:
There is an unneeded file in the 7.x-1.x branch called webform_classes.infor
ventral.org/pareview reports 0 errors
codesniffer locally reports 0 errors
coder reports 1 small nitpick:
Manual testing: After adding a field, viewing the form, then clicking edit on the form to view the classes, a class of "webform" is automatically inserted.
Comment #2
carlhinton commentedThe module will already allow you to add multiple classes to a component; simply leave a space between the classes that you add to the classes field.
Comment #3
carlhinton commentedThanks for spotting the unneeded file - this has now been removed
Comment #4
carlhinton commentedI have added the space into line 59
Comment #5
carlhinton commentedI have contacted the guys caring for webform via email. I am awaiting their response.
Comment #6
KrisBulman commentedIf it already allows for multiple classes, the help text should state as much.
Comment #7
carlhinton commentedGood point - I have updated the code to include this in the description for the field. The update is in git.
Comment #8
KrisBulman commentedClosing this as it's a duplicate of #1623178: [D6] webform classes
Comment #9
avpaderno