Aether

There are multiple errors in the code.

* README.txt is missing, see the guidelines for in-project documentation.
* Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
* Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
* Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

Refer to the attached file

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

• Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.
• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Needs more work, see attached ventral report

- redundant code in the user category template.
- format c will not return the right time stamp for pubdate, see #1183250: Add a theme_datetime() function to consistently theme dates and datetimes

There's some talk here about the CSS formatting - however this theme uses SASS so these should be accepted - focus should be on the SASS files and forget about the actual generated CSS - the SASS compiler handles that and is very hard to change certain things - it would be onerous to expect theme developers to manually change the compiled CSS files.

manual review:

1. template.php: no need to determine the theme path as you are including files from your own theme which you already know where they are. Use something like require_once dirname(__FILE__) . '/mymodule.inc';
2. array_interlace(): all functions that you define need to be prefixed with your theme's name to avoid name collisions.
3. html5.js appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms. The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org. Same for the other JS files.

But apart from that this looks nearly ready. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Looks fixed to me.

Sorry, wrong status.

Removing review bonus, please do more reviews to get a quicker approval.

Regarding the JS libraries: then all those themes are doing it wrong. They should add instructions how to retrieve those libraries instead of duplicating them all over the place. Drupal core could be considered a somewhat exception as it provides a foundation for any contributed project and to ensure that they all use the same library version.

Anyway, as the libraries seem to be all GPL compatible this is annoying, but not an application blocker for me.

Thanks for your contribution, KrisBulman! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.