Closed (fixed)
Project:
Yandex.Metrics
Version:
7.x-2.x-dev
Component:
Code
Priority:
Minor
Category:
Task
Assigned:
Reporter:
Created:
17 Jun 2012 at 12:26 UTC
Updated:
2 Feb 2013 at 08:10 UTC
Jump to comment: Most recent file
Hey, guys. First of all - thanks for your work.
And my request is - in function yandex_metrics_page_build(&$page) (859 yandex_metrics.module)
remove style="clear: both;"
Instead add any class or id
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | yandex_metrics-invoke_css_remove_style-1643374-10.patch | 1008 bytes | man-1982 |
| #6 | rename_class_invoke_css_in_code.patch | 10.77 KB | man-1982 |
| #2 | added_class_ym_clear.patch | 10.57 KB | man-1982 |
Comments
Comment #1
Konstantin Komelin commentedGood advice! Thank you!
I'm going to include this improvement to the 2.x branch.
Comment #2
man-1982 commentedRemove style="clear: both;" and added class ="ym_clear"
Comment #3
kalabroI guess "ym-counter" will be more semantic name for this stuff. What do you think about it?
Comment #4
Konstantin Komelin commentedI agree. I'll take it into account when I will be commiting it.
Comment #5
Konstantin Komelin commentedI've reviewed patch #2.
It seems you don't activate yandex_metrics.css.
Please take a look at drupal_add_css.
--
Проверил патч #2.
Кажется, ты не не активировал yandex_metrics.css.
Посмотри на drupal_add_css.
Comment #6
man-1982 commentedRenamed class, added invoke function drupal_add_css in code.
Comment #7
kalabroLet's add new line at the end of files.
Looks like yandex_metrics.css is placed in $path . '/yandex_metrics.css'
My git thinks that there is no css folder:
Maybe it's only my problem.
Stuff for reviewing patches: http://drupal.org/project/dreditor
Comment #8
kalabroHm. Problem with css folder solved for me.
Your git diff uses --no-prefix option I guess.
Only new line at EOF needed. I think it is RTBC. Thanks!
Comment #9
Konstantin Komelin commentedPHPStorm is good but let's use clean git commands for patches. http://drupal.org/node/1054616
--
PHPStorm хорош, но давайте юзать чистый Git из консоли, чтобы проблем не было.
Comment #10
man-1982 commentedCreate patch through git diff
Comment #11
Konstantin Komelin commentedCommited patch #10
http://drupalcode.org/project/yandex_metrics.git/commit/22c8c88
Comment #12
Konstantin Komelin commentedOkay, Andrey, let's do the same thing for 6.x-2.x.
Comment #13
Konstantin Komelin commentedI've done the same for 6.x-2.x.
Commit: http://drupalcode.org/project/yandex_metrics.git/commit/c8d2ec0
Comment #14
Konstantin Komelin commentedNo more work is required here.