Hey, guys. First of all - thanks for your work.

And my request is - in function yandex_metrics_page_build(&$page) (859 yandex_metrics.module)
remove style="clear: both;"
Instead add any class or id

Comments

Konstantin Komelin’s picture

Version: 7.x-1.3 » 7.x-2.x-dev
Assigned: Unassigned » Konstantin Komelin
Status: Active » Needs work

Good advice! Thank you!
I'm going to include this improvement to the 2.x branch.

man-1982’s picture

Status: Needs work » Needs review
StatusFileSize
new10.57 KB

Remove style="clear: both;" and added class ="ym_clear"

kalabro’s picture

I guess "ym-counter" will be more semantic name for this stuff. What do you think about it?

Konstantin Komelin’s picture

I agree. I'll take it into account when I will be commiting it.

Konstantin Komelin’s picture

Status: Needs review » Needs work

I've reviewed patch #2.
It seems you don't activate yandex_metrics.css.
Please take a look at drupal_add_css.
--
Проверил патч #2.
Кажется, ты не не активировал yandex_metrics.css.
Посмотри на drupal_add_css.

man-1982’s picture

Status: Needs work » Needs review
StatusFileSize
new10.77 KB

Renamed class, added invoke function drupal_add_css in code.

kalabro’s picture

Status: Needs review » Needs work
+++ css/yandex_metrics.css	(revision )
@@ -0,0 +1,3 @@
+}
\ No newline at end of file

Let's add new line at the end of files.

+++ yandex_metrics.module	(revision )
@@ -160,9 +160,11 @@
+    $path = drupal_get_path('module', 'yandex_metrics');
+    drupal_add_css($path . '/css/yandex_metrics.css');

Looks like yandex_metrics.css is placed in $path . '/yandex_metrics.css'

My git thinks that there is no css folder:

`--> git st
# On branch 7.x-2.x
nothing to commit (working directory clean)
`--> git apply -v --check --summary ../rename_class_invoke_css_in_code.patch
Checking patch yandex_metrics.css...
Checking patch yandex_metrics.module...
 create mode 100644 yandex_metrics.css

Maybe it's only my problem.

Stuff for reviewing patches: http://drupal.org/project/dreditor

kalabro’s picture

Status: Needs work » Reviewed & tested by the community

Hm. Problem with css folder solved for me.

git apply -v --check --summary -p 0 ../rename_class_invoke_css_in_code.patch

Your git diff uses --no-prefix option I guess.

Only new line at EOF needed. I think it is RTBC. Thanks!

Konstantin Komelin’s picture

Status: Reviewed & tested by the community » Needs work

PHPStorm is good but let's use clean git commands for patches. http://drupal.org/node/1054616
--
PHPStorm хорош, но давайте юзать чистый Git из консоли, чтобы проблем не было.

man-1982’s picture

Status: Needs work » Needs review
StatusFileSize
new1008 bytes

Create patch through git diff

Konstantin Komelin’s picture

Status: Needs review » Reviewed & tested by the community
Konstantin Komelin’s picture

Status: Reviewed & tested by the community » Needs work

Okay, Andrey, let's do the same thing for 6.x-2.x.

Konstantin Komelin’s picture

Status: Needs work » Fixed
Konstantin Komelin’s picture

No more work is required here.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.