Are there plans to port this to Drupal 6.x? What would be necessary to do so? Any chance it would mostly work as-is?

CommentFileSizeAuthor
#52 taxonomy_access-HEAD-24.06.2008.zip58.36 KBivrh
#32 de.po17.64 KBFrankT

Comments

lichter’s picture

Hi,

Indeed this is an interesting question.

Drupal 6.x is out for a while now, can we hope for a taxonomy_access for 6.x family? :)

If I can help with migration please let me know.

Thank you,
Lichter

dinis’s picture

No immediate plans to move our production site 6 yet, but I'd be more than happy to get a 6.x build of this superb mod running on a test server.

nekobul’s picture

Hi,

I have created a D6 compatible version of the TAC module. Please contact me to send you a version to test it.

keve’s picture

Many thanks for nekobul for the D6 version.
Commited to HEAD.

Nekobul:
I also deleted hook_disable() no need for it in D6: http://drupal.org/node/114774#node_access_enable

Please, rewview it.

Spacio’s picture

Hi,

I'm interested for it !

nekobul’s picture

maz-1’s picture

Deleting taxonomy terms in the Drupal 6 Version does not work.

The Fix:
replace $form_values with $values in the taxonomy_access_admin_form_submit function of the taxonomy_access_admin.inc file

acosta.edgar’s picture

Can you create a 6.x branch? otherwise, what is needed to include this module in the filtered lists of modules for Drupal 6?

keve’s picture

It is not tagged as Drupal6, yet. Please, use the head version for testing. (You can see a link above #6).

viadimezzo’s picture

No errors, works as it has to work. Thank you :-)

brianmercer’s picture

In order to get deletion of permissions working and replacing $form_values with $values in function taxonomy_access_admin_form_submit, I see seven instances of $form_values. Replace them all? I did replace them all and it seems to be working. I just want to make sure.

Disabling an entire rank does not work. Instead of a confirmation form, I get a double Page Not Found.

simonaustin’s picture

Thank you for the dev version. I'm very interested in a stable release.

Boinng’s picture

I'd just like to +1 my support for this - I won't be moving to 6.x until this module is tested and working, it's far too useful and important - in fact I'd encourage the inclusion of something like this in the Drupal core.

japanitrat’s picture

works nice on the first look ! thank you!

hope there will be a tagged, stable release soon, cause this one is a major module for all drupal-sites, i think.

magnus’s picture

Category: feature » task

I have used the HEAD and made the changes as mentioned in comment #7. It works quite good.
I do have one problem though. My site is both private (authenticated users) and public. I have set up a couple of forums for the private and also one forum for the public. I have no problem with the restrictions for the private forum, but when I make the public forum accessible for anonymous users and they make an reply the thread disappears.
In TAC I set for anonymous users:
Global
default - D D D

Forum
Open forum (this is my forum container for the forum "Open discussions"') - A A A List
Open discussions (this is my forum for anonymous users) - A A A - Create List

In "Permissions"
I even gave the anonymous users full access to everything, but still things screws up.

I also have two terms for making a node private or public, but that's not included in the forum. I set the restrictions for anonymous users to public and that works.
So it seems that it is just making comments for anonymous users that screws up.

brownjeans’s picture

What's the status on the v6 general release of this module?

djsnapshot’s picture

Category: task » feature

Am also very ineterested in having a stable version of TAC for v6.

Thanks a lot for putting this HEAD version out for testing!

josuealcalde’s picture

subscribing

PF’s picture

I'm also very interested in the stable release of this module.

magnus’s picture

Anyone else who have the same problem as I mentioned in comment #15?

IgD’s picture

I'm also very excited about a version for Drupal 6.x. I hope you can get this out soon!

magnus’s picture

Found a small bug that made translation of two strings impossible.
In taxonomy_acess_admin.inc on row 142-143

     '#title' => '<em>default<em>',
     '#description' => 'can\'t be disabled without disabling TAC for this role'

should be

     '#title' => t('<em>default</em>'),
     '#description' => t("can't be disabled without disabling TAC for this role"),

Still haven't got any success in the problem in comment #15 :(

dfrkp’s picture

I'm also very excited about a version for Drupal 6.x. I hope you can get this out soon!
--subscribe =)

AveryN’s picture

I'm also looking forward to a formal release! ...subscribe

TyraelTLK’s picture

subscribe

webchick’s picture

Note: If you want to see this out sooner than later, instead of simply subscribing, actually *test* http://ftp.drupal.org/files/projects/taxonomy_access-HEAD.tar.gz and report back with your results. The more people who chime in and report problems or (alternately) report that everything's working fine, the sooner it'll get listed as an official release.

nationalwind’s picture

I've installed it for a rather simple system of limiting access for a number of groups to each have access to a group-specific page. So far it works great! I'll post any issues, of course, as they arise.

FrankT’s picture

Just a very very little thing: the translation standards say that the po files should be in a subdirectory 'translations'; so far they are in a directory 'po' yet...

FrankT’s picture

Hi, I found several strings that can be translated using (http://localhost/?q=admin/build/translate/search), but which are not in the de.po (and not in taxonomy_access.pot):

The content access permissions have been rebuilt.
Access control for user roles based on taxonomy categories.
The content access permissions need to be rebuilt. Please visit <a href="@node_access_rebuild">this page</a>.

There are also strings that cannot be found in both places:

this action rebuilds...
grants for [role]
Taxonomy access control (menu entry)

I think it would be best to build a new taxonomy_access.pot.

In my opinion on the page 'grants for [role]' (in one case it was http://localhost/?q=admin/user/taxonomy_access/edit/2) there should be an explanation text what A I and D means, so that this explanation can be translated, too.

Thanks and regards!

ediww’s picture

for a second i've been thinking that this module is integrated in Drupal. shame :/

anyway, giving a try, but, please, advise if this mod will be supported or not.

magnus’s picture

Priority: Minor » Normal

It's not released even as dev, but I used the proposed files for Drupal 6.x and made my own POT and also uploaded the Swedish translation. You can find it here http://drupal.org/files/issues/taxonomy_access.sv_.zip if you want the POT. If you want to build your own POT you could use this http://drupal.org/project/potx
I usually use this as the POT included in a release is usually outdated.

FrankT’s picture

StatusFileSize
new17.64 KB

Appended to this comment there is a new de.po, updated with the pot-file mentioned above. I modified some strings in the former de.po to match with other translation (taxonomy module e.g.), also some minor misspellings have been removed.

The translation is complete now, maybe not perfect in every way yet.

magnus’s picture

Category: task » feature

Finally I got this working as I want to. In my user table I had user 0 missing. Everything worked fine except posting through taxonomy_access.
Well, now it works as I want to after I inserted user 0 through phpmyadmin.

sebos69’s picture

Hi!
I tried the HEAD version for Drupal 6. I installed the module (it is listed as installed, version=HEAD), but I have no menu "taxonomy access control" in the admin section.
Is there something more to do?

sebos69’s picture

OK, I figured it out : I was using an account with administrative rights, but not the first admin account (the one created during site installation). When using the first admin account, the taxonomy access menu is visible, but not with other administrator accounts. Is there a way to fix that?

Thank you anyway for this module.

Kuling’s picture

Priority: Normal » Minor

I also do not have any problems right now. All steps of installation didn't produce problems.

cpugeniusmv’s picture

#35: Assign the "administer taxonomy" permission to the role you have assigned to the admin accounts.

nonsie’s picture

I haven't tested it extensively yet but it appears that a user with administer taxonomy permission is unable to delete assigned taxonomy access permissions.

cpugeniusmv’s picture

#38: See if #7 in this issue addresses your problem. You might also check out #249471: Error when trying to disable TAC for a role

sebos69’s picture

>> #35: Assign the "administer taxonomy" permission to the role you have assigned to the admin accounts.

I did, but the menu still does not show up. Only the admin account has it. This is not a big issue for now.

An other issue:

when adding a taxonomy term to a page in order to limit its access to anonymous users, it works well.
But if I remove the tag, the page stays invisible to anonymous users. I tried to rebuild access data, but it did not do anything. Also, when editing the given page, the tag is not present, so the problem is somewhere else.

grimsy’s picture

subscribing

vadim.bich’s picture

Priority: Normal » Minor

Reporting:

I just have this module loaded and have not set up any access rules yet. When I am deleting my custom node along with the term, I am getting this.

Call to undefined function _taxonomy_access_get_nodes_for_term() in E:\EasyPHP\www\main\modules\taxonomy_access\taxonomy_access.module on line 224

I am going to disable TAC for the time being...

magnus’s picture

Have you followed the fix in http://drupal.org/node/166080#comment-746917?

nationalwind’s picture

Installed May 19. Encountered no issues. now using it on live site *gasp*

BioALIEN’s picture

I've tried the link provided by webchick in #26 and here are my findings.

The task is to establish a private forum with this module. I setup a new role (moderator) and configured all the settings. When it came to assigning the TAC permissions, I set it so that only moderators are able to see the private forum. anonymous and authenticated users were unable to access the forum even if they visit the links directly.

The result: it works (tm).

igorjava’s picture

Hi everyone.
I am using Drupal 6.x and instaled HEAD version of TAC. I can TAC module on modules lists.
When I enable it and save configuration I get following warning

The configuration options have been saved.
The content access permissions need to be rebuilt. Please visit this page.

I made 3 different groups and also 3 different levels of access and now I want to set role access control with the TAC but when I go to
administer > user management > taxonomy access: permissions i dont see TAC.
All i see in my list of admin options when I go to administer/user management is following

* Access rules
* Permissions
* Profiles
* Roles
* User settings
* Users

Anyone have any suggestions please?

Thank you

BioALIEN’s picture

Status: Active » Needs work

@igorjava, sort the administer page by module ;)

@all, since my post above, I've had some more time to experiment and it seems this module has some problems:
1. One cannot delete TAC permissions after setting them.
2. One cannot disable TAC roles.
3. For some reason, TAC seems to be messing up the news on the front page. The "moderator" role I created to have special TAC previliges seem to get an extra page in the homepage "Pager" and when you click on this, it leads to 404. Disabling this module or accessing the site via admin/user/guest don't appear to have this problem.

There are no other modules on my test site, so I am 100% sure it's down to this module. As a result, I am setting this to CNW.

igorjava’s picture

Hi
I did sort admin page by module and TAC module is not there.
I think using TAC is only way to have 3 different groups who can see different content.
I thought that I could create different content type for each group and that would solve it but for each group to view
their own content I have to go to role/permissions and check "view content" which in turn enables all content and shatters my idea of defining different content for different roles.

Thanks

magnus’s picture

igorjava: Did you follow the link:
"The configuration options have been saved.
The content access permissions need to be rebuilt. Please visit this page."
and rebuilt the permissions? If not, visit /admin/content/node-settings

BioALIEN: Did you apply the fix in comment #7?

magnus’s picture

edit - double post

igorjava’s picture

Hi. Thanks for reply.
I did all the things you suggested. I will follow suggestion for post 7 and see if that will bring
the TAC options on my admin page.

Thanks

ivrh’s picture

StatusFileSize
new58.36 KB

Here's the updated HEAD, taken from #6 with updates from #7 and #22. If someone could update the HEAD with this patched version in the location in #6 would be great. As this looks a bit silly to make this thread so long with people talking about those changes.

cpthomp’s picture

I downloaded the previous HEAD, and the one from #52. I updated my permisions after enabling the TAC module, but I have problems similar to #34. I currently don't have access to the "first" admin account (they're on vacation) any solutions to this yet?

Anonymous’s picture

I have tried the version posted in comment #52 today.
The only problems I have found so far is that disable doesn't work
It sends me to this url: admin/user/taxonomy_access/delete/4 and says "Page not found".
A half decent workaround until this is fixed, would be to delete all rules inside the settings for that role and setting the Global default back to it's default values.

I'm going to try using it on a semi-development-production site for a while. I'll report back if I find any other issues.

cpugeniusmv’s picture

Anonymous’s picture

#55: Yes that seems to fix it. Thanks!

ronniead’s picture

Im a newb - just installed Drupal 6 a few weeks ago. This functionality seems fantastic, and in my mind should be part of core. Can HEAD be used in production? count me in for D6 support.

brahms’s picture

To the module maintainer(s):

First I'd like to thank you for this awesome module. I am also very interested in seeing an official 6.x release soon. But following this issue here I think testing and keeping an overview of the modifications in the head release would be a lot easier if you would provide "official" development snapshots for a 6.x branch on the project page. Then we would not have to relate our test reports to some files and patches linked to specific comments around here but woild be able to relate to the release date of the dveloper snapshots.

And I suggest this approach for the 5.x-2.x-dev branch too.

By the way: at first glance both releases (taxonomy_access 5.x-2.x-dev and taxonomy_access-HEAD.tar.gz) seem to work fine on my sites. But as access control needs to be secure I know I have to test them more in detail.

cpugeniusmv’s picture

Version: master » 6.x-1.x-dev
Assigned: Unassigned » cpugeniusmv
Status: Needs work » Fixed

I've committed all of the code fixes provided in this thread into the 6.x branch in CVS, there should be a 2008-07-21 dev release available in a few hours.

Please test it and create new issues for additional problems. Thanks!

keve’s picture

Good job. :)

alphex’s picture

very interested in this as well, looking forward to the official 6.x release.
Thanks

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

kroimon’s picture

Priority: Minor » Normal
Status: Closed (fixed) » Active

hey!
how far is the development of the 6.x port? any plans to release?

cpugeniusmv’s picture

Status: Active » Closed (duplicate)