Add views sort on subscriber count

Moving to the right queue. OG Project is only about integrating OG and project.module (well, at this point, really project_issue.module).

good advertisement for your patch :)

i'll try to review that patch and push it along. i won't commit this until that one is in.

This will be very useful. Thanks, Doug!

Re-rolled patch for head

looks to be missing the is_active check for a subscription

looks fine now

This version uses now-kinda-standard capital "OG" in the UI text.

I'm using OG 5.x-5.4 on Drupal 5.7, but it seems i cannot make these patches work. :(

user warning: Unknown column 'og_count' in 'order clause' query: SELECT DISTINCT(node.nid) FROM node node WHERE (node.type IN ('og_user_roles_subgroup','group')) ORDER BY og_count DESC LIMIT 0, 10 in includes/database.mysqli.inc on line 151.

og_count should be in the SELECT clause.
It seems that the $query->add_subquery() isn't called.
Only the ORDER BY clause is updated (maybe using that $query->orderby[], but I'm not sure the handler is called at all!).

I don't know how to make the patch work.
Some hours ago, I opened a topic forum at http://drupal.org/node/230773

I'm using drupal 5.7, og 5.x-5.4, views 5.x-1.6. Nothing is patched.

sites/all/modules/views> patch.exe -p0 -b < 143888_3.patch
patching file views.module
patching file views_cache.inc
patching file views_query.inc

sites/all/modules/og> patch.exe -p0 -b < 166244_2.patch
patching file og_views.inc
Hunk #1 succeeded at 250 (offset 10 lines).
Hunk #2 succeeded at 1304 (offset 10 lines).

It seems all goes patched ok.
But when I create a new view, the OG: Group: Subscriber Count field is still not sortable. :(

I'm a new Drupal user, should I make other things to apply the patch?
However, I'll try to retry with a fresh installation and to look into the code during the week.

Hmmm... the patch seems to install fine, the option shows up under the Sort Criteria, but the sorting doesn't actually take place (see attached screenshots).

@mr. andrey - you have to patch Views and OG for this to work ... still waiting on Views for this.

@moshe, ah, I see.

I tried to patch views with http://drupal.org/node/143888#comment-815243, which made no difference.

Thanks,
Andrey.

@mr.andrey

instead try the patch:
http://drupal.org/node/143888#comment-555015

Ah, got it. That worked.

Is that patch eventually going to end up included in views? Do you know?

Thanks,
Andrey.

Any news on this ??

I am desperate for this... I have no clue how to patch.

Can I have a patched VIews module and OG module

Thank you

Cheers

Just to confirm I've got it all working well with the latest two patches.

One thing to note: make sure you clear the cache (easy with the devel module) so that you can see the 'subscriber count' sort criteria after you've patched og_views.inc.

Droople, there's info on how to patch at: http://drupal.org/patch/apply

The real fix is under discussion at #336500: Og Statistics Module

Marking this is a dupe as I have no intention of committing it. Folks are welcome to use the patches here, of course.