Navigation breaks if two items in album have identical sort criteria

Did this make it into the Aug 15 dev snapshot?

I've installed that version and am seeing some funny behavior in this album:

http://womensfooty.com/album/hotties/western_region

When the album is sorted alphabetically, the pager is all messed up. I click on the first picture and it displays but #2 is highlighted. "Next" brings me to #4 then #6 and finally 7,8,9 are ok.

Is this a new bug or the same thing?

I just did a little bit of investigating on this issue and have some progress to report.

I have an album that is sorted by title. I've found two cases that break the pager navigation:

1. If a title has a single quote in it ("Who's da man?"), this causes the node query in _acidfree_get_offset_in_parent() to include the node being checked in the query result. I worked around this by adding "and n.nid != %d" to the query string and passing $node->nid as a query parameter.

2. Titles that start with a lower case letter. It looks like acidfree is somehow doing some queries with a case insensitive comparison on the title and others case insensitive. The last three titles in my album are
"Who's da man? Timmy!", "x3 Baby!" and "Yay Cathy!". The pager wants to set them up in that order. However when _acidfree_get_offset_parent() is executed it includes this term in rhe order by :

CONCAT(rpad(n.title, 32, ' '), LPAD(n.nid, 10, '0')) < 'x3 BABY! 0000001362';

and that includes "YAY Cathy! ...." in its results.

This seems to be caused by some weird type issues in mysql

select 'x1362' < concat('Y', 1363)
vs
select 'x1362' < concat('Y', cast(1363 as char))

In _acidfree_filter_clause i added the cast to the last clause for 'nid' and my album seems to be sorting correctly now. I realize that my fix isn't correct as the cast syntax is a mysql extension to standard SQL (i think).

EDIT: the mysql documentation http://dev.mysql.com/doc/refman/5.0/en/cast-functions.html#function_cast says that CAST() is standard SQL so maybe my workaround isn't so bad.

Here's a patch for the changes I've made. Still needed on the development snapshort released on 2008-02-11