Needs work
Project:
Subscriptions
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
30 Jun 2012 at 16:09 UTC
Updated:
24 Feb 2020 at 01:31 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
robin monks commentedComment #2
salvisThat's very interesting.
Unfortunately I get
when I try to add the Subscribe link field.
EDIT: Yes, I've cleared all caches.
Comment #3
robin monks commentedStupid me forgot the menu callbacks for this from the original module; I'll re-roll later.
Comment #4
leomaru79 commentedAny progress to fix this? I'm having this issue too and need to put a subscribe link in one of my Views. Any workaround?
Comment #5
Patribus commentedsame here!
Comment #6
robin monks commentedBarring natural disaster I'll make a new patch this weekend; that, of course, stops no one from re-rolling it before I get the opportunity (somehow managed to forget about this issue >.<)
Comment #7
robin monks commentedAlright, this should fix things back to a working state; and is based off of 7.x-1.1 (which apparently contains part of my broken patch...somehow?)
This add views links support and menu hooks via tabs, although it's not clear if tabs are desired. In any case it works.
Comment #8
robin monks commentedAlternative a/b patch in proper git format; because PHPStorm is being mean to me.
Comment #9
Patribus commentedHello, I'm trying to apply the patch using this method here http://drupal.org/node/14231#comment-22776.
But somehow I get an error. I did manage it once with another patch, but not with yours.
Can you indicate me how to patch the module files on a windows desktop basis?
thanks
EDIT1: well, i found now this http://drupal.org/node/60179 and I'm using the NetBeans Software to apply the patch
Comment #10
salvisThe current instructions are on http://drupal.org/patch/apply
Comment #11
salvisFeedback?
Comment #12
Patribus commentedit's working fine ;-) (is that the feedback you wanted ?)
Comment #13
vuilThe patch #8 is ready to be committed! Thanks.
Comment #14
salvisI meant to commit this, but I found some open issues.
I fixed these:
— move the functionality into its own module in the directory 'views'
— fix a number of t() calls with variable arguments
— improve the look of the option on the content type pages
— add check for 'subscribe to content' permission
This needs work:
— remove the variables in hook_uninstall() to avoid having state that persists across reinstalls
Nice to have:
— add a filter and sort for this virtual field