It seems like the reported errors generated by the two systems are very different.. too different!

drush coder-review webform -y
phpcs --standard=Drupal webform.module

phpcs with Drupal standard per installation page http://drupal.org/node/1419988 generates a huge number of errors.

What is going on?

CommentFileSizeAuthor
#5 coder-review-results.txt6.09 KBchriscalip
#5 drupalcs-results.txt80.39 KBchriscalip

Comments

das-peter’s picture

das-peter commented

I guess you've compared the outputs to be able to create this ticket, it would be nice if you could attach those outputs.
Then we're able to compare them too.

chriscalip’s picture

chriscalip commented
Status: Closed (works as designed) » Active

Updated comment per request:
http://drupal.org/node/1670316#comment-6220632

Drupal Coder Review Results

chriscalip’s picture

chriscalip commented

Updated comment per request:
http://drupal.org/node/1670316#comment-6220632

Drupal Code Sniffer Results

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Closed (works as designed)

Yes, drupalcs is a lot more strict than coder and does not report that many false positives. Please do not directly paste such long reports in your comments, better add them as txt file attachments.

chriscalip’s picture

chriscalip commented
StatusFileSize
new drupalcs-results.txt80.39 KB
new coder-review-results.txt6.09 KB
chriscalip’s picture

chriscalip commented
Status: Active » Closed (works as designed)

Agreed! Such a refreshing development of a tool that provides a better service than the existing accepted tool for testing coding standards, Drupal Coder Review. Drupal Code Sniffer is a good addition to our drupal testing ecosystem!

Cannot wait to fully deploy in conjunction with phing, jenkins, phpunit, etc..