Advanced Entity Tokens (AET)

There are Many Drupal coding standard issue. Please look at the link

http://ventral.org/pareview/httpgitdrupalorgsandboxeyalshalev1664648git-...

Automatic review

Add @file block to aet.tokens.inc and aet_view.tokens.inc.
See http://drupal.org/node/1354#files

Also there should be no trailing spaces.

Manual review

1. You could add "package" to you .info files to group your modules under the same package. It would be easier to find and enable them.
2. Typo in aet.tokens.inc, line 91, 151, 296 and aet_view.tokens.inc line 73: santize instead of sanitize.

I tried quickly with Token example... but I need a more real use case.
I'll do it tomorrow.

Cedric

Hi Eyal Shalev,
After a quick review I just can tell you that users would be grateful if you had time to implement hook_help()

/**
  * Implement hook_help()
  */
function yourmodulename_help($path, $arg) {
switch ($path) {
case 'admin/help#yourmodulename':
   $output = '';
   $output .= '<h3>' . t('About') . '</h3>';
   $output .= '<p>' . t("A helpful entry about your module") . '<p>';
return $output;
   }
}

Thank you!

hook_help() is absolutely no requirement - therefore no major issue - therefore no reason to set needs work

Review of the 7.x-1.x branch:

• ./README.txt: the byte order mark at the beginning of UTF-8 files is discouraged, you should remove it.
• ./aet.module: the byte order mark at the beginning of UTF-8 files is discouraged, you should remove it.
• ./aet.tokens.inc: the byte order mark at the beginning of UTF-8 files is discouraged, you should remove it.
• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:
"$info['types']['aet']['description'] = t('AET Description');": not a very useful description?

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Thanks for your contribution, Eyal Shalev!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on irc in #drupal-contribute. So, come hang out and stay involved! Thanks again, and good luck! :)