Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Jul 2012 at 21:36 UTC
Updated:
26 Jul 2012 at 06:33 UTC
devel inline is a module that empersize the execute code form of devel module. It's give you option to see all of the available classes, interfaces and hooks. Why hooks? you can defined a temporary hooks for debugging the hooks interaction in your site with out edit the files. This is also good for debugging the hooks on the live site.
Made for drupal 7.
Clone:
git clone --branch 7.x-1.x RoySegall@git.drupal.org:sandbox/RoySegall/1645754.git
Comments
Comment #1
brazorf commentedHello there,
1. you should remove LICENSE.txt as it will be automatically added by drupal packager
2. run pareview, there are a couple of things to be fixed there
Regards,
brazorf
Comment #2
roysegall commentedfixes applyed, checked using code review.
Comment #3
mitchell commentedThank you for contributing this Roy! It looks very interesting. Installation went fine, but I'm having trouble using it. Maybe write up a step by step guide on how to do something in particular with the module. If you want some help with the copy review or translation, I can help with that if you'd like.
Comment #4
roysegall commentedThere is no a "step by step". I wrote it in the readme file - all you need to do is to start write a code in the dvevl php execute code form and then you get an auto complete of the functions - just like a normal IDE.
Another thing i'd like to mention - this module is still beta and i whant to get out from sandbox so more people code download it easily and help make it a better one. I think there is a great potential in this module.
Comment #5
rho_ commentedPasses pareview, code is clean and legible, installs cleanly, and works as described.
It does seem that it's fairly easy to confuse the autocomplete, but this seems to be noted in the README, and covered by "beta."
I did a bit of googling to see if something like this exists already, and was unable to find anything similar.
Overall, good job! REALLY cool module. I would love to see this developed further.
Comment #6
rho_ commentedMeant to switch back to needs review in my last post. whoops
Comment #7
roysegall commentedStill need work on the reademe file.
Comment #8
roysegall commentedOK, i made a better read me file and write it down in the module(It's an AWSOME read me file).
I think this module can go from sandbox to an early beta module for feed backs and suggestion by other users.
Comment #9
roysegall commentedSomeone?
Comment #10
roysegall commentedPlease guys - can some one give me a response?
Comment #11
patrickd commentedWe do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.
Sorry
Comment #12
vaibhavjainFirstly , you link to GIT is not correct, should be - http://git.drupal.org/sandbox/RoySegall/1645754.git
Results from automated review - http://ventral.org/pareview/httpgitdrupalorgsandboxroysegall1645754git
Comment #13
roysegall commentedI applied the two fixes.
Comment #14
patrickd commenteddon't forget to switch back to needs review
Comment #15
mitchell commentedIMHO, this one is ready. I tested the module, scanned the code, and see that ventral doesn't recommend anything else.
I don't see any minimum recommended time in the workflow for the RTBC state (self-reminder: todo), but I would prefer to complete this one soon. I think 12hrs or 24hrs is reasonable, so @other-reviewers, please confirm or make another state change before then if you have a few min.
Comment #16
roysegall commented@mitchell, i didn't understood - does the module ok?
Comment #17
mitchell commentedOne last issue (normal priority, so no hold up), #1699210: The project's name should be uppercased and canonical.
Comment #18
mitchell commented@RoySegall: Thanks for fixing #17.
> @mitchell, i didn't understood - does the module ok?
I'll translate for you.. and also for the fun of it.. I very rarely write in Hebrew, so your corrections would be appreciated :) ..רק הייתי בעולפן ב
אני חושב שזה מוחן. בדקתי המדול, קריאתי הקוד, ורואה שוינתראל לא הפקיד אוד מהשהו.
אני לא רואה שיש זמן מומלץ קטן ביותר בהטקסי..
rtbc (מהומה בישבילי),
אבל אני מעדיף להשלים אלה בקרוב. חושב 12ש"ע או 24ש"ע מספיק, אז @אמבקרים אחרים, בבקשה תאש ותעשה אוד שינוי להטקסי ליפני זה אמ יש לחה שנייה.
My next follow should come shortly, granting access. :)
Comment #19
mitchell commentedThanks again for your contribution, RoySegall!
I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on irc in #drupal-contribute and #drush. So, come hang out and stay involved! Thanks again and good luck! :)
Comment #20
roysegall commentedI'll fix the typos:
הייתי באולפן ב....
אני חושב שזה מוכן. בדקתי את המודול, קראתי את הקוד, ואני רואה שוינתראל לא הפיק משהו מיוחד.
אני לא רואה שיש זמן מומלץ מינמאלי אבל אני מעדיף להשלים את זה בקרוב.
אני חושב ש12-24 שעות זה מספיק, אז מבקרים אחרים, אנא תאשרו ותיישמו שינויים.
Thank you very much mitchel. i hope this module will improve. As i said, he have great potential.
Comment #21
mitchell commented#20: Very cool. Thanks for the corrections.
Best wishes.
Comment #21.0
mitchell commentedMinor fixes.