Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Jul 2012 at 16:49 UTC
Updated:
23 Jul 2012 at 22:11 UTC
git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/rballou/1630324.git view_mode_pageThis module allows site builders to assign a URL for different view modes related to a specific content type. In conjunction with modules like Display Suite, which allow you to add custom view modes, you can display the same node in different ways.
%) in this pattern.For Drupal 7
Comments
Comment #1
c4rl commentedThis is just my opinion, but I feel strongly that the word "page" is used too often in Drupal to mean many, many different things. Instead of the name "view mode page," would you consider naming this project "view mode path" or "view mode url?"
Comment #2
cedeweyI have used this module and it is very useful. It will definitely be a good addition to the Drupal module ecosystem.
Comment #3
Jeffrey C. commentedAutomated Review:
An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.
You can find the results of the automated report at http://ventral.org/pareview/httpgitdrupalorgsandboxrballou1630324git.
Comment #4
prathK commentedHi,
I have reviewed your module manually. code looks neat and useful functionality of module.
There is one minor suggestion from me for better understanding for developers.
on line : 29 view_mode_page.module
if (!$is_node_page || $is_node_page && !$is_display_overview) {
it becomes developer friendly when we specify braces in the code and machine friendly too as braces
specify precedence as well.
Above code line can be re-written as
if (!$is_node_page || ($is_node_page && !$is_display_overview)) {
Or
if ((!$is_node_page || $is_node_page) && !$is_display_overview) {
whichever is applicable in your case.
Other stuff seems fine to me. Nice use of features api and hooks.. :)
Cheers,
prathK
extrimity.in
Comment #5
rballou commentedThank you all for the reviews! I have made the changes for number 3 & 4.
Comment #6
cedeweyReviewed, nice work.
Comment #7
sreynen commentedHi rballou,
Thanks for your contribution and welcome to the community of project contributors on drupal.org.
I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects, at your discretion.
Now that you've experienced the full review process, please consider reviewing other projects that are still awaiting review. Anyone can help with reviews, following the guidelines.
Comment #8
c4rl commentedAny response to comment #1? :)
Comment #9
sreynen commentedc4rl, I don't think this is a good place to discuss something as broad as the meaning of "page" in Drupal. As you said, "page" is used in Drupal to mean many different things, so that should be a wider discussion, maybe on http://groups.drupal.org/coding-standards or http://groups.drupal.org/code-review
FYI, this review process has a history of turning new contributors off of Drupal entirely by refusing them Git access until they deal with issues veteran contributors regularly ignore. There's not much risk of that in this case, but I'm still pretty wary of anything that seems like an unnecessary hurdle.
Comment #10
c4rl commentedSure, I understand and agree that "page" has implications beyond this project.
This isn't a blocker, just a suggestion that "view mode path" might be a more descriptive name if the contributor agrees. If not, no problem.